Skip to content

BUG: Fix aneurysm repeating-timer callback argument mismatch #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lassoan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BUG: Fix aneurysm repeating-timer callback argument mismatch #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion svmorph/visualization/interactor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
from svmorph.core import mesh_data
from svmorph.core.units import L, unit_name
from svmorph.core.defaults import (
ANEURYSM_MAX_RADIUS_DEFAULT_CM,
STENT_DIAMETER_DEFAULT_CM,
STENT_LENGTH_DEFAULT_CM,
SMOOTHING_K_CM,
Expand Down Expand Up @@ -102,6 +103,7 @@ def __init__(self, mesh, centerline, mesh_filename, centerline_filename, mesh_ac

self.sharpness = 1.0
self.force_scale = -1.0
self.aneurysm_radius = ANEURYSM_MAX_RADIUS_DEFAULT_CM * L()
self.stent_radius = (STENT_DIAMETER_DEFAULT_CM / 2) * L()
self.stent_length = STENT_LENGTH_DEFAULT_CM * L()
self.smoothing_k = SMOOTHING_K_CM * L()
Expand Down Expand Up @@ -132,7 +134,7 @@ def key_press_event(self, obj, event):

def timer_callback(self, obj, event):
"""Repeating timer callback that drives one sequential deformation step."""
self.deform_mesh_aneurysm(self.sharpness, self.force_scale)
self.deform_mesh_aneurysm(self.sharpness, self.force_scale, self.aneurysm_radius)

def key_release_event(self, obj, event):
"""Handle key-release events. Releasing 'd' destroys the deformation timer."""
Expand Down Expand Up @@ -469,6 +471,8 @@ def lock_camera(self, position):

def deform_mesh_aneurysm(self, sharpness, force_scale, aneurysm_radius):
"""Run one step of the aneurysm deformation pipeline."""
# Remember the target so the repeating-timer path continues with the latest value
self.aneurysm_radius = aneurysm_radius
if len(self.selected_points) < 1:
logger.warning("Please select the distal start of the stent along the centerline.")
return
Expand Down
Loading