Conversation
The repeating deformation timer (hold 'd') called deform_mesh_aneurysm with only sharpness and force scale, but the method also requires the target aneurysm radius, so the timer path raised TypeError on every tick. Store the target radius as an interactor attribute (initialized from ANEURYSM_MAX_RADIUS_DEFAULT_CM like the other deformation parameters and refreshed on every deform_mesh_aneurysm call) and pass it from the timer callback. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current situation
Holding the
dkey (repeating aneurysm deformation timer) crashes withTypeError:timer_callbackcallsdeform_mesh_aneurysmwith two arguments, but the method requiresthree since the
aneurysm_radiusparameter was added in 1583c46. The GUI button pathpasses all three and is unaffected. Trivial self-contained fix, no tracking issue.
Release Notes
dkey crashed on every timer tick. Thetarget radius is now stored as an interactor parameter (like
sharpness/force_scale)and passed by the timer callback. No API or behavior changes otherwise.
Documentation
None needed, it restores the documented
d-key behavior; no public API change.Testing
Full test suite passes (35 passed); module imports cleanly and all
deform_mesh_aneurysmcall sites verified to pass the required arguments. The timer path itself is GUI-interactive
(VTK key events) and outside the automated suite's coverage.
Code of Conduct & Contributing Guidelines