Repository navigation
ci: scaffold with the theme layer and build it - #79
Merged
Merged
Conversation
The scaffold job runs on template defaults, where nuxt4:battlestack-theme is off because the theme is not on npm yet, so no CI job ever loaded the layer: dependency bumps to @battlestack/theme (e.g. @nuxt/kit in #76) went green untested. The new job scaffolds nuxt4-minimal with the theme enabled, links the theme to the checkout, and runs prepare, lint, typecheck and a production build. Verified locally that it fails when the theme's nuxt.config.ts is broken.
--skip-install leaves the starter's pnpm-lock.yaml behind, which no longer matches the manifest the features wrote, and pnpm installs frozen under CI=true. The CLI's own install passes --no-frozen-lockfile for the same reason.
@battlestack/theme is on npm (1.3.0); the scaffold job skips the layer because the feature is default-off, and enabling it would test the published package.
christian-at-sevenlab
approved these changes
Oct 15, 2026
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The CI scaffold job uses template defaults, and
nuxt4:battlestack-themeis off by default, so no CI job ever loads the theme layer. Turning it on wouldn't help either: the project would install the published@battlestack/themefrom npm, not the PR's version. Dependency bumps to the theme went green without being tested. #76 (@nuxt/kit) is the latest example; I tested it by hand in #77.What
A new
scaffold-themejob:nuxt4-minimalwith--features nuxt4:battlestack-theme --skip-install@battlestack/themeat the checkout (link:) and installseslint --fix, which--skip-installotherwise skipsnuxi prepare, lint, typecheck and a productionnuxt buildNo Postgres or Docker: the goal is to prove the layer loads and builds.
Verified locally
main. The theme's font shows up in the built CSS, so the layer actually loaded.@nuxt/kitimport broken, bothnuxi prepareand the build fail.Keep this job even if the theme becomes default-on. The main scaffold job would still install the published theme, so only the
link:tests the theme in the PR.To make it blocking, add Scaffold with the theme layer and build it to the required checks in branch protection.