Repository navigation
ci: require the theme scaffold job, and apply the ruleset - #92
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The live "Require CI to pass" ruleset still required only the original six checks:
.github/rulesets/require-ci-to-pass.jsonin ci: require a changelog entry for changes that ship #85, but the file was never applied.Both checks ran but blocked nothing.
What
require-ci-to-pass.jsonadds Scaffold with the theme layer and build it, pinned to GitHub Actions (integration_id: 15368) like the others.docs/repository-settings.mdlists it as well.22024012) is already updated from this file, somainnow requires all eight checks. Its bypass list, target and strict setting were checked to be unchanged; it has one rule (required_status_checks), as the file does.No
packages/change, so no changelog entry.