Repository navigation
Bind script sharing to the AI recipient and harden DB viewer writes - #781
Merged
Merged
Conversation
Renaming an output variable now rewrites every reference through one traversal (templates in any field, dynamic machine/credential bindings, breakpoint conditions, decision cases and edge conditions). Copy, paste and duplicate allocate a fresh alias per copy and rewrite the copy's own references. The server rejects two active nodes with the same alias, case-insensitively, and ignores disabled nodes when indexing aliases. Inserting an activity on a conditional edge keeps the guard in front of the new activity. Command-palette edge deletion goes through the normal delete command, and property edits snapshot history before the first change of a typing burst. Clipboard copies also mask recognised secrets in edge data and string arrays. Closes #689, #703, #693, #694, #595. Refs #574. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A save, lock change, publish or run started for one workflow no longer acts on another workflow opened before it finished: mutations carry the workflow id they were started for, and completions check the editing session through the new useAsyncIdentity hook plus the draft generation in useWorkflowPersistence. The CRUD editors (credentials, machines, users, global variables, maintenance windows, custom activities, alerting rules and policies) and the admin settings sections lock the form while a save is pending and ignore a late success for a record that is no longer open. Closes #692, #690. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Property panels follow undo and restored drafts: an edge resyncs its condition mode and switching to the simple condition clears the expression; the agent host list adopts restored values. Text-file delete can select line-range and pattern mode, waitForCondition stores the displayed portOpen default 443 and flags a missing host or port, and scheduledTask registration accepts only built-in or managed service accounts, matching the ServiceAccount logon type the engine uses. The run-history step details label the shown configuration as the current draft and show the recorded target machine. The SCCM/AD demo fixture uses braced interpolation; the example-script harness now parses every demo fixture script. Closes #695, #601, #702, #705, #603, #698. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Script generation sends the editor content only to the recipient the user approved: capabilities expose a recipient key per active profile (profile id, endpoint, model, sharing switch), the dialog keeps consent only for that key, and the server rejects a stale key with 409 LLM_RECIPIENT_CHANGED before creating a client. The workflow and knowledge assistants derive their history context from the same key. The database viewer runs a write only after the confirmation phrase, also when Run is pressed again while the dialog is open; the dialog is a modal with a focus trap. Chat persistence no longer interrupts sending when browser storage is blocked or full, keeps the newest history within a size budget and tells the user what survives a reload. Closes #688, #691, #701. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+196
to
200
| if (!dict.TryAdd(variable, node.Id)) | ||
| throw new InvalidOperationException($"Duplicate active output variable '{variable}'."); | ||
| } | ||
| } | ||
|
|
This was referenced Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth of five stacked PRs (on top of #780). Until the earlier ones are merged this diff also shows their commits; the change of its own is the top commit.
What changes
GET /api/ai/knowledge/capabilitiesreturnsscriptContextRecipientKeyfor privileged users. The prompt dialog keeps the "share current script" consent only for that key and drops it when the key changes.generate-scripttakesexpectedRecipientKey; when the script is shared and the key no longer matches the active profile,ScriptGenerationServicethrowsRecipientChangedbefore a client is created and the API answers409 LLM_RECIPIENT_CHANGED. The editor reopens the dialog and refreshes capabilities.LlmHistoryContext.Key(profile id, endpoint, model, sharing switch). The workflow and knowledge assistants derive their history context from it too, replacing two separate hash formulas; the workflow assistant now also drops history on a model change. Docs updated accordingly.Not included
The recipient-bound history replay changes from the audit branch (
contextBoundHistory, knowledge-chat history slicing) belong to #674, which was already fixed by #740, and are left out.Tests run locally
dotnet test tests/NodePilot.Ai.Tests(844)dotnet test tests/NodePilot.Api.Tests --filter AiController|AiKnowledgeController|AiChatController|LlmProfileDefaults|AiStream(76), including the new 409 casedotnet test tests/NodePilot.Cli.Tests --filter ApiDtoParity(8)tsc -p tsconfig.app.json --noEmit, ESLint on the touched filesCloses #688
Closes #691
Closes #701
🤖 Generated with Claude Code