Repository navigation
Restore paused debug state from REST and fix the live event envelope - #782
Merged
Merged
Conversation
Renaming an output variable now rewrites every reference through one traversal (templates in any field, dynamic machine/credential bindings, breakpoint conditions, decision cases and edge conditions). Copy, paste and duplicate allocate a fresh alias per copy and rewrite the copy's own references. The server rejects two active nodes with the same alias, case-insensitively, and ignores disabled nodes when indexing aliases. Inserting an activity on a conditional edge keeps the guard in front of the new activity. Command-palette edge deletion goes through the normal delete command, and property edits snapshot history before the first change of a typing burst. Clipboard copies also mask recognised secrets in edge data and string arrays. Closes #689, #703, #693, #694, #595. Refs #574. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A save, lock change, publish or run started for one workflow no longer acts on another workflow opened before it finished: mutations carry the workflow id they were started for, and completions check the editing session through the new useAsyncIdentity hook plus the draft generation in useWorkflowPersistence. The CRUD editors (credentials, machines, users, global variables, maintenance windows, custom activities, alerting rules and policies) and the admin settings sections lock the form while a save is pending and ignore a late success for a record that is no longer open. Closes #692, #690. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Property panels follow undo and restored drafts: an edge resyncs its condition mode and switching to the simple condition clears the expression; the agent host list adopts restored values. Text-file delete can select line-range and pattern mode, waitForCondition stores the displayed portOpen default 443 and flags a missing host or port, and scheduledTask registration accepts only built-in or managed service accounts, matching the ServiceAccount logon type the engine uses. The run-history step details label the shown configuration as the current draft and show the recorded target machine. The SCCM/AD demo fixture uses braced interpolation; the example-script harness now parses every demo fixture script. Closes #695, #601, #702, #705, #603, #698. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Script generation sends the editor content only to the recipient the user approved: capabilities expose a recipient key per active profile (profile id, endpoint, model, sharing switch), the dialog keeps consent only for that key, and the server rejects a stale key with 409 LLM_RECIPIENT_CHANGED before creating a client. The workflow and knowledge assistants derive their history context from the same key. The database viewer runs a write only after the confirmation phrase, also when Run is pressed again while the dialog is open; the dialog is a modal with a focus trap. Chat persistence no longer interrupts sending when browser storage is blocked or full, keeps the newest history within a size budget and tells the user what survives a reload. Closes #688, #691, #701. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GET /executions/{id}/paused-steps returns one redacted snapshot per
waiting breakpoint (step id, label, pause time, reason, variables)
instead of step ids, and the CLI and MCP mirror it. The designer
hydrates paused variables from it, replaces the REST baseline on
hydration and replays only events received during the request, and
re-hydrates known runs after a reconnect.
Debug overrides are validated once in DebugOverrides, before the pause
is consumed: globals.* and reserved keys return 400 and the step stays
paused. The inspector keys its drafts to one pause and makes only run
inputs and step results editable.
Live-Ops, the dashboard and the execution pages decode the server's
{type, event} batch envelope through normalizeBatchItem and reconcile
after a reconnect; the demo hub sends the same envelope. E2E 59.2 now
covers the snapshot-based inspector.
Closes #606, #696, #697, #706.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+196
to
200
| if (!dict.TryAdd(variable, node.Id)) | ||
| throw new InvalidOperationException($"Duplicate active output variable '{variable}'."); | ||
| } | ||
| } | ||
|
|
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last of five stacked PRs (on top of #781). Until the earlier ones are merged this diff also shows their commits; the change of its own is the top commit.
What changes
GET /api/executions/{id}/paused-stepsreturns oneDebugPausedStepSnapshotper waiting breakpoint (stepId,stepLabel,pausedAt,reason, redactedvariables) instead of a list of step ids.IWorkflowEngine.GetPausedStepsbecomesGetPausedSnapshots;np exec paused-stepsprints label, reason and time; MCPlist_paused_stepsreturnspausedStepsinstead ofpausedStepIds. The snapshot is a copy of the values the liveStepPausedevent carried.useWorkflowSignalRfetches steps and paused snapshots together, replaces the REST baseline and replays only the events received during that request. After a reconnect every already hydrated run is hydrated again, so gaps from the disconnect close.DebugOverrides.Validateis the single check (count, key, size;globals.*and__*rejected). The controller returns 400 andDebugHandle.Resumethrows before the pause is consumed, so a rejected override leaves the step paused instead of failing the run after resume.stepId:pausedAt) and to the execution; onlymanual.*and step results are editable.{type, event}. Live-Ops/dashboard/execution pages decode it through the sharednormalizeBatchItem(they only readEvent/evtand fell back to polling), the demo hub sends the real shape, and history pages invalidate after a reconnect.docs/workflow-designer-features.md, E2E section 59.Tests run locally
dotnet build NodePilot.slnx: 0 errorsdotnet test tests/NodePilot.Engine.Tests --filter Debug|ForEachActivityExecution|WorkflowSchedulerTests(70)dotnet test tests/NodePilot.Api.Tests --filter ExecutionDebug|EndpointClientCoverage(19)dotnet test tests/NodePilot.Cli.Tests --filter NodePilotApiClientResources|ApiDtoParity|Exec(96)dotnet test tests/NodePilot.Mcp.Tests --filter ExecutionControlTools|DocumentationCounts|ToolCatalog(34)tscfor app and demo,npm run lint:ci(10 warnings, all pre-existing)e2e-demo(needs the demo build), covered by CICloses #606
Closes #696
Closes #697
Closes #706
🤖 Generated with Claude Code