Skip to content

feat(diagnostics): complete syntax diagnostic lifecycle - #18

Merged
Seddryck merged 1 commit into
mainfrom
feat/end-to-end-syntax-diagnostics
Aug 14, 2026
Merged

feat(diagnostics): complete syntax diagnostic lifecycle#18
Seddryck merged 1 commit into
mainfrom
feat/end-to-end-syntax-diagnostics

Conversation

@Seddryck

Copy link
Copy Markdown
Owner

Summary

  • map parser byte spans to precise zero-based LSP UTF-16 ranges across multiline and Unicode input
  • turn zero-width or out-of-bounds parser spans into deterministic, useful minimal squiggles
  • cover diagnostic publication, replacement after edits, and clearing on document close
  • preserve the parser-derived diagnostic details and document version

Validation

  • dotnet build src/Expressif.LanguageServer/Expressif.LanguageServer.csproj --configuration Release --framework net10.0 --runtime win-x64 --no-restore --nologo -m:1 /nodeReuse:false
  • dotnet test src/Expressif.LanguageServer.Core.Tests/Expressif.LanguageServer.Core.Tests.csproj -f net10.0 -r win-x64 --no-restore --nologo --verbosity minimal -m:1 /nodeReuse:false (11 passed)
  • dotnet test src/Expressif.LanguageServer.Tests/Expressif.LanguageServer.Tests.csproj -f net10.0 -r win-x64 --no-restore --nologo --verbosity minimal -m:1 /nodeReuse:false (9 passed)

Closes #15

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Seddryck, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 109 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6637ae63-092e-498c-a343-872c77ff3c54

📥 Commits

Reviewing files that changed from the base of the PR and between bc09ea2 and 61df3a3.

📒 Files selected for processing (3)
  • src/Expressif.LanguageServer.Tests/SyntaxDiagnosticMapperTests.cs
  • src/Expressif.LanguageServer.Tests/TextDocumentSyncHandlerTests.cs
  • src/Expressif.LanguageServer/Diagnostics/SyntaxDiagnosticMapper.cs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Seddryck
Seddryck marked this pull request as ready for review August 14, 2026 06:20
@Seddryck
Seddryck merged commit 6d355af into main Aug 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Complete end-to-end syntax diagnostics

1 participant