Skip to content

feat(completion): add function-name completion - #25

Open
Seddryck wants to merge 2 commits into
mainfrom
feat/function-name-completion
Open

feat(completion): add function-name completion#25
Seddryck wants to merge 2 commits into
mainfrom
feat/function-name-completion

Conversation

@Seddryck

Copy link
Copy Markdown
Owner

Summary

  • advertise and handle standard LSP function-name completion requests
  • detect valid completion positions through Expressif.Syntax parser probes and exclude literal contexts
  • load authoritative names, aliases, descriptions, categories, and signatures once through Expressif.Functions.Introspection
  • replace the complete typed function token with an explicit LSP text edit
  • preserve Expressif XML documentation in build and publish outputs for descriptive introspection

This branch is based on feat/end-to-end-syntax-diagnostics from #15 / PR #18 as requested.

Validation

  • dotnet build Expressif.LanguageServer.sln --configuration Release --no-restore --nologo -m:1 /nodeReuse:false (succeeded for .NET 8, 9, and 10 with no warnings)
  • dotnet test src/Expressif.LanguageServer.Core.Tests/Expressif.LanguageServer.Core.Tests.csproj --configuration Release --framework net10.0 --runtime win-x64 --no-restore --nologo --verbosity minimal -m:1 /nodeReuse:false (19 passed)
  • dotnet test src/Expressif.LanguageServer.Tests/Expressif.LanguageServer.Tests.csproj --configuration Release --framework net10.0 --runtime win-x64 --no-restore --nologo --verbosity minimal -m:1 /nodeReuse:false (10 passed)
  • git diff --check

Closes #16

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Important

Review available on request

  • 🔍 Trigger review

Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment @coderabbitai review to review the latest changes. For a full review, comment @coderabbitai full review.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ab6b9442-1bda-48cc-a598-b834c590e8d0


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Seddryck
Seddryck marked this pull request as ready for review August 15, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add function-name completion

1 participant