Repository navigation
fix(store): isolate import claims and wait for registration admission - #27
Merged
Seagulls merged 1 commit intoNov 7, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the two merge blockers in Liquid-co#141, as a fork-only follow-up to #18.
Unix admission now locks a persistent sidecar beside the resolved database instead of opening and closing the SQLite inode. Symlink/relative aliases share the sidecar; hard-linked databases explicitly fail closed because independent adjacent sidecars cannot coordinate arbitrary hardlink aliases safely.
Ordinary registration and path edits wait up to 30 seconds, polling every 100 ms, with a distinct busy error and HTTP 409 instead of a false ownership-overlap error. The claim covers ownership preparation through commit. Interactive request cancellation stops admission waiting. Imports retain immediate refusal and their existing extraction/registration/recovery protection. Windows retains its pinned-thread mutex and uses the common bounded waiter.
Validation at cc685d7:
All local tests used disposable state and synthetic saves. No deployed services or live saves were touched. No durable power-loss recovery is claimed.
This PR is intentionally unmerged. Its base is also the source of upstream Liquid-co#141: merging here would update both fork #18 and upstream Liquid-co#141. Opening this follow-up does not change either source branch. Upstream publication remains a separate step.