Skip to content

fix(store): isolate import claims and wait for registration admission - #27

Merged
Seagulls merged 1 commit into
fix/upstream-backup-import-on-131from
fix/pr141-sidecar-bounded-wait
Nov 7, 2026
Merged

Seagulls merged 1 commit into
fix/upstream-backup-import-on-131from
fix/pr141-sidecar-bounded-wait

Conversation

@Seagulls

@Seagulls Seagulls commented Nov 7, 2026

Copy link
Copy Markdown
Owner

Addresses the two merge blockers in Liquid-co#141, as a fork-only follow-up to #18.

Unix admission now locks a persistent sidecar beside the resolved database instead of opening and closing the SQLite inode. Symlink/relative aliases share the sidecar; hard-linked databases explicitly fail closed because independent adjacent sidecars cannot coordinate arbitrary hardlink aliases safely.

Ordinary registration and path edits wait up to 30 seconds, polling every 100 ms, with a distinct busy error and HTTP 409 instead of a false ownership-overlap error. The claim covers ownership preparation through commit. Interactive request cancellation stops admission waiting. Imports retain immediate refusal and their existing extraction/registration/recovery protection. Windows retains its pinned-thread mutex and uses the common bounded waiter.

Validation at cc685d7:

  • Focused race regressions passed three times, including 24 disjoint registrations across two Store handles, waiting, timeout classification, cancellation, ownership recheck, POSIX-lock preservation and existing import/recovery cases.
  • Full non-E2E race suite, go vet, Linux/Windows amd64 CLI builds, macOS arm64 vet, and Windows Store test compilation passed locally.
  • Exact-head fork push CI passed: https://github.com/Seagulls/OpenSave/actions/runs/42383218623 (native Windows and E2E results are available in that run).

All local tests used disposable state and synthetic saves. No deployed services or live saves were touched. No durable power-loss recovery is claimed.

This PR is intentionally unmerged. Its base is also the source of upstream Liquid-co#141: merging here would update both fork #18 and upstream Liquid-co#141. Opening this follow-up does not change either source branch. Upstream publication remains a separate step.

@Seagulls
Seagulls merged commit f2a341e into fix/upstream-backup-import-on-131 Nov 7, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant