Repository navigation
fix(backup): prevent untracked import from overwriting another game's owned root - #141
Conversation
|
@Seagulls is attempting to deploy a commit to the sivadaboi's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi, how is this one coming along? #138 is the one fix from your batch we'd like in 2.5.0, since it can change another game's save. Is it close to ready for review, or is anything blocking it that we can help with? |
|
Thanks for checking in. Yes, the fix for #138 is implemented, and we're keen to get it ready for 2.5.0. The implementation has already passed focused native HTTP/SQLite regressions covering primary, named and nested-root ownership collisions, separate-process admission, rollback after injected errors, and race-enabled tests. The remaining blocker was the dependency on #131. I see that #131 has now merged, so the next step is to rebase #141 onto the updated "dev-public", reconcile the final ownership API, and rerun exact-head validation. I'll keep the change scoped to the untracked backup-import defect, remove the now-merged prerequisite changes from the PR diff, and report back with the validation results before marking it ready for review. Thanks for prioritising this for 2.5.0. |
|
Thanks, the import flow itself is what we want: the safety copy, the recovery, and not rolling back a registered game. Two changes to the claim before we can merge:
|
fix(store): isolate import claims and wait for registration admission
|
Thanks, Omar — both requested claim corrections are now published at f2a341e, preserving history with a normal merge of correction cc685d7.
The import safety copy, recovery and committed-registration behaviour are retained; imports still refuse immediately when admission is busy. Focused race checks passed three times, full non-E2E race tests and vet passed, and platform compile checks passed. Both fork push CI and fork PR CI passed all ten jobs, including native Windows race tests and all six E2E shards. Upstream CI for the new merge head is pending. The PR description now reflects the revised contract and evidence. |
|
Thanks, both work. With the separate lock file and the bounded wait, 24 simultaneous registrations of separate folders all succeed here, and the store, API and daemon tests pass when merged with dev-public. Two things before we merge:
|
…61109 fix(store): keep metadata updates available during backup imports
|
Thanks, Omar — you’re right on both points, and thanks for catching what we overlooked. Metadata-only updates should not be blocked by an import, and the conflict resolution needs to preserve #139’s topology protection. Both corrections are now published at The new regression verifies metadata updates during held import admission and relocation refusal/cancellation. Local race suites, vet and Linux/Windows builds pass. CI for this exact head has now passed all ten jobs, including Linux/Windows race tests, all six E2E shards, frontend and Decky checks. Thanks again for the careful review. |
Fixes #138.
Untracked portable backup imports could overwrite another tracked game's primary, named or nested save root before registration rejected the ownership collision.
Scope
This import fix incorporates dev-public@fdcce2445c71 and merged #131. Published history is preserved without force-pushing.
Review corrections and validation
Both requested claim corrections were implemented at cc685d7 and merged through fork PR #27.
Current upstream PR head: 02859f6 (documentation-only cleanup after the normal merge of the validated correction). The supplementary docs file has been removed; only implementation and regression-test changes remain.
Limits
No durable filesystem transaction journal: returned-error rollback does not establish SIGKILL or power-loss recovery. Noncooperating older binaries/external tools, concurrent alias replacement and symlink swaps are outside the admission contract. Unix hardlinked databases are refused rather than claimed safe. The 30-second bound covers acquisition, not subsequent operation duration. No live saves or deployed services were touched.
No daemon takeover, peer provisioning, topology redesign is included.
9 November review follow-up
Published head:
9435e8012e036d91c4abb32b01e0657b7817f7bb, a normal merge of fork PR #28, validated source0fe57b490d0f0c6b7d9a38c8ba6d388045b36ace.Upstream CI for the published merge head is pending; validated fork-head results do not substitute for that run. No live saves or deployed services were touched.