Repository navigation
fix(code-index): keep progress observation timestamps monotonic - #4740
Closed
ScriptedAlchemy wants to merge 1 commit into
Closed
ScriptedAlchemy wants to merge 1 commit into
ScriptedAlchemy wants to merge 1 commit into
Conversation
|
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Refs #4508 (partial correctness guard, not the capture/graph instrumentation the issue still needs).
The build-progress slot admits snapshots from concurrent producers under one owner epoch. A producer can take its
last_progress_microssample before another producer but acquire the publication lock afterward. Previously, the later publication overwrote the slot's last-observed timestamp with an earlier time even though the slot'sprogress_epochadvanced. This can make the progress freshness indicator regress.Change
last_progress_microsacross publications belonging to the same generation owner; do not mutate the committed counters, current phase, blocked reason, or ownership checks.replace_generationresponsible for clearing the slot. Even an A→B→A remount starts a new timestamp sequence under its new owner epoch.Validation and remaining work
The master blobs, isolated two-file diff, source-shape anchors, final newlines, and trailing whitespace were checked. Rust compilation, Bazel tests, and host CI have not run in this environment. CI must compile and execute the new regression on this PR's isolated branch; source review is not a test pass. No runtime throughput or latency improvement is claimed.
This is deliberately not a full fix for #4508. Capture/parse progress, actual graph-publication work counters, and a live large-project end-to-end acceptance run still remain. Keep #4508 open. The separate PR-repair automation owns hosted CI repair and any authorized merge.