Repository navigation
fix(code-index): fence stale progress boundaries and repeated refusals - #4795
Closed
ScriptedAlchemy wants to merge 5 commits into
Closed
ScriptedAlchemy wants to merge 5 commits into
ScriptedAlchemy wants to merge 5 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #4508 — partial correctness repair; issue remains open. This PR protects truthful report ordering for the existing text-artifact phase; it does not yet instrument pre-seal capture/parse or native graph publication.
Root cause addressed
The live build-progress slot accepted delayed reports from a matching owner even if their committed page/chunk/import/payload counters were lower, or after the text owner had already reached
Ready. Repeated publication of the same blocked reason also increasedprogress_epochwithout any changed status. In addition, an incompatible/missing text-artifact staging file can legitimately restart its build without changing the generation or scheduler owner; a naive global counter-monotonicity check would hide that restart and freeze the report.Implementation
Readytransitions within the same staging attempt.progress_epochand rejecting a stale owner.Readytransition that clears a previously reported refusal.Readyretreat, owner replacement, verified staging reset/continued commits with clock continuity, repeated blocked events and clearing upon a real commit, unchanged-phase retry deduplication and resumed text completion, including same-phaseReadyclearing a prior refusal. Existing assertions are preserved.Only two files change under
crates/tracedecay-code-index-runtime, via five ordinary fast-forward commits based on master91c72aba7750a398dd28e83d64bf0c6d6fef4172; all pushes used exact expected-head nonforce updates.Validation and review gates
No Bazel execution is claimed: the tool execution environment has no Bazel workspace/toolchain. Hosted native CI must run the exact PR head with
bazel test //crates/tracedecay-code-index-runtime:unit_test --test_output=errors, plus applicable Rustfmt/build/CI gates. The PR-triggered workflow has reportednative=nonein its run title; static CI alone is not a substitute for native Rust tests. Independent review is still required. Do not merge on metadata checks alone.Still necessary for #4508
Add genuinely measured pre-seal capture/parse progress and committed native graph page/segment publication reports; verify all stages and restarted/resumed status polling end-to-end on a cold large repo, including stalled/refusal semantics. Only then consider Fixes #4508 and closing the issue on master.
No release, infrastructure, decision-model, or Kev changes. This PR is independent of protected draft #4776, which must not merge.
Latest update (2026-11-08)
Commit
d62e730b65c7066691d071ad93e7d55fbca6ee56adds the no-op phase guard and one production-path resumability regression. It is a candidate fix, not a tested pass: GitHub Actions on this head is queued withnative=none; Bazel-native Rust execution and independent review are still absent. Graph page/segment and pre-seal capture/parse work producers remain unimplemented. Keep the PR unmerged pending proof.CI-blocked history; replaced without rewriting
Hosted Repository gates on run 42432012520 failed because immutable commit
9dca677has a 75-character header (72 maximum). Under the required no force/rewrite/discard policy, this PR branch and its commits are preserved unchanged. The same two file trees were recreated as an ordinary new commite287f491d278fc16862aa7c0d252226407a63193from currentmaster, onfix/4508-progress-boundaries-ci-clean; this PR is retired in favor of its single active replacement. #4508 is still incomplete and must remain open.