Repository navigation
fix(graph): surface failed sealed generation retirement - #4716
Closed
ScriptedAlchemy wants to merge 3 commits into
Closed
ScriptedAlchemy wants to merge 3 commits into
ScriptedAlchemy wants to merge 3 commits into
Conversation
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
Apply the already-reviewed fixture repair from fbca068 (#4731) to this branch after its private Linux run failed at the redundant generation-publication wait. The original fixture blob matches exactly. Keep the stronger fresh serving-seat wait and all admission assertions. No deadline increases, production changes, or validation skips. The shared repair passed native Linux on #4731; this branch's new integration still requires its own hosted Bazel validation. No local Rust execution is claimed.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Refs #4616; does not complete sealed-generation collection.
Return a typed error when a retired or quarantined generation's sealed directory cannot be removed, including retries after its in-memory reader has gone. An absent directory remains an idempotent success. Refuse a poisoned reader registry; warn on failures in the separate best-effort staging cleanup path. Collection eligibility, reader protection, leases and journals are unchanged.
The regression places a regular file in the exact artifact directory slot, requires deletion to fail without losing those bytes, then verifies successful retry and idempotent replay.
Shared CI fixture repair
Commit
5e1906a371970119b2c2c4f029bc470fa2407ff4applies the exact reviewed fix from #4731. This branch's private Linux run failed two ignored-dependency admission tests while waiting for a generation-publication event that could fire before subscription. The fixture now uses its existing stronger fresh serving-generation check directly. All behavioral assertions and that check's deadline remain intact.The original fixture blob was identical to #4731's parent; the published replacement is exactly
9135cf4f9077156831e3f0bb0141f40b99503b65. This is a targeted follow-up on the existing branch, not a history rewrite or a merge into master.Validation
The shared fixture repair passed native Linux on #4731 (private run 41665062193). That result does not validate this updated branch's graph-retirement integration. Fresh exact-head CI is pending in https://github.com/ScriptedAlchemy/tracedecay/actions/runs/41706621169.
No local Rust compilation, Bazel tests or rustfmt ran in this repair environment. No assertions, admission controls or test workloads were weakened. Full applicable hosted validation remains required before merge.
Ordinary missing-generation sweeps, retention fairness, unsafe-artifact isolation, reclaim guidance and the reported large-store resource measurements remain outside this PR. Keep #4616 open.