Repository navigation
fix(retention): retry failed graph staging releases - #4723
Closed
ScriptedAlchemy wants to merge 1 commit into
Closed
ScriptedAlchemy wants to merge 1 commit into
ScriptedAlchemy wants to merge 1 commit into
Conversation
Preserve an earlier staging-release failure when the independent graph replay release page reports Complete, Retained, or MoreWork. That keeps the existing short retry cadence instead of parking failed staging cleanup behind the full maintenance interval. Refs #4616
|
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This was referenced Nov 3, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The maintenance owner invokes graph-staging cleanup and then independently processes a graph-replay release page. In
reconcile_graph_replay_releases, a failedrelease_one_sealed_generation_staging_rowscall already logsgraph_staging_release_failed, and its cursor correctly stays unchanged. However, a successful (or empty) release page then returnedComplete,Retained, orMoreWork, overwriting the failure. With no other work or backlog, the caller can report a successful full tick and park the failed staging cleanup until the normal long maintenance interval.Fix
Failedbehavior for malformed release evidence, cancellation, or a failed graph replay.A failing staging release now keeps the maintenance owner's existing short retry cadence. This avoids mistaking a logged failed cleanup for a completed tick; no new scheduler, backoff, journal, or destructive path is introduced.
Validation
store_maintenance/mod.rsand the two independent graph maintenance paths; the caller mapsReconcileOutcome::FailedtoCodeGenerationRetentionOutcomeV1::Failedwhile allowing independently planned generation collection to continue.masteratb47a5d3f: 49 insertions, 4 deletions, no other production paths changed.//crates/tracedecay-maintenance:unit_testand the registered retention journey.Scope
Refs #4616 (partial). This repairs a silent cleanup retry failure. It does not implement the missing sealed-generation collector, unsafe text-artifact isolation, bounded lock starvation, Doctor reclaim guidance, or 70-generation storage-report resource acceptance. Keep #4616 open. This PR intentionally avoids overlapping #4716 (typed sealed-directory deletion errors) and #4714 (bounded metadata scanning).
The branch is a single, non-force commit against the current default branch; it does not alter any other open PR branch. The separate PR-repair automation owns CI follow-through and merges.