Skip to content

fix(release): upload only the beta archive as the binary artifact #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScriptedAlchemy merged 1 commit into from
Sep 18, 2026
Merged

fix(release): upload only the beta archive as the binary artifact #1600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/release-beta.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,10 @@ jobs:
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: beta-${{ matrix.name }}
path: tracedecay-beta-*
# The exact archive, not `tracedecay-beta-*`: that glob also matched
# the MCPB packaged beside it, so publish found MCPBs among the
# binaries and refused the whole release (beta.43).
path: tracedecay-beta-${{ env.RELEASE_TAG }}-${{ matrix.name }}.${{ matrix.archive }}
if-no-files-found: error

publish:
Expand Down
15 changes: 15 additions & 0 deletions scripts/test-check-release-artifacts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,21 @@ def main() -> int:
(root / "binaries" / "tracedecay-beta-v1.2.3-windows.zip").unlink()
(root / "mcpbs" / "tracedecay-beta-v1.2.3-windows.mcpb").unlink()
run(root, False, profile="beta", allow_missing=True)
# An MCPB that leaked into the binaries directory (a `tracedecay-beta-*`
# artifact glob did this) is foreign there, in both modes.
for child in ("binaries", "mcpbs"):
for item in (root / child).iterdir():
item.unlink()
for target in manifest["include"]:
(root / "binaries" / (
f"tracedecay-beta-v1.2.3-{target['name']}.{target['archive']}"
)).write_bytes(b"artifact")
(root / "mcpbs" / (
f"tracedecay-beta-v1.2.3-{target['name']}.mcpb"
)).write_bytes(b"artifact")
(root / "binaries" / "tracedecay-beta-v1.2.3-linux.mcpb").write_bytes(b"artifact")
run(root, False, profile="beta")
run(root, False, profile="beta", allow_missing=True)
print("release artifact validator tests passed")
return 0

Expand Down
Loading