fix(release): upload only the beta archive as the binary artifact - #1600
Merged
Merged
Conversation
The beta build job uploaded its binary artifact with path tracedecay-beta-*, which also matched the MCPB packaged beside it. publish then found MCPBs in the binaries directory and refused the whole release; on beta.43 that was the only thing between four green builds and shipped assets. The artifact now names the exact archive, as the stable workflow already did.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
beta.43: all four targets built (first time since #707), then
publishfailed inAssemble retained and newly built prerelease assets:The beta build job's binary artifact was uploaded with
path: tracedecay-beta-*, which also matches the.mcpbpackaged in the same directory.publishcopiesnew-binaries/tracedecay-beta-*intobinaries/, so the MCPBs landed among the archives, and the coverage checker (correctly) refused foreign files. The old strict checker would have refused identically; no earlier tag ever reached this step.release.ymlalready uploads the exact archive name — the beta workflow now does the same.Also pins the checker behaviour with a test: an MCPB in the binaries directory is foreign in both strict and
--allow-missing-targetsmodes.Evidence:
scripts/test-check-release-artifacts.py,actionlint,tests/release_safety_test.shpass. beta.43's tag workflow is frozen with the glob, so the first tag to ship is beta.44.