fix(ci): retire queued checks after native policy changes - #344
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 6495606 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Updating an Action pin changes its policy digest. When native CI then owns the same PR head, queued checks from the earlier policy can remain pending because their policy does not match the new receipt.
Scope
Accept any well-formed native policy receipt from the latest exact-head PR workflow. Delegation still requires the exact requested policy. Planning includes valid queued prior-policy checks for known lanes only when that native refusal exists.
Move native-marker cancellation entirely into serialized drains. Before cancellation, recheck the current PR head, native receipt and exact queued check. Enqueue only declines new admission. Add regression coverage, a patch Changeset and regenerated artifacts.
Tradeoffs
This retires queued markers on open PR heads with validated native ownership. It does not retire closed PRs, unknown lanes or active checks. A valid old-policy delegated receipt remains untouched.
Verification
pnpm build: passed, including host validation.pnpm check: passed (artifact freshness, validation, build, typecheck, diagnostics, Action, unit, route and browser suites).