perf(ci): plan worker lanes before allocating runners - #342
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 8e3d776 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixed CI matrices allocate a runner for every lane even when no PR is ready. A read-only preflight can identify execution and queued-check maintenance before the caller expands its worker matrix.
Scope
Add Action mode
planwith JSONlanesand numericcountoutputs. Planning and draining share admission checks for trusted PRs, exact merge parents, delegation receipts, repository gates, completed verdicts and retryable work. The planner reads each PR's checks and receipt once across its lanes. Drains retain all mutations and revalidate after acquiring their existing lane lock.Update the caller example to use the planned matrix, add a patch Changeset, and regenerate the committed plugin artifacts.
Tradeoffs
The planner itself needs one lightweight job. Its result is advisory, and
in_progresschecks remain eligible for recovery because check state alone does not establish whether a prior worker still exists. This does not introduce an ownership protocol or claim a measured CI speedup.Blast Radius
Existing
draincallers keep their interface and admission rules. Planning includes queued conflict and native-fallback cleanup, but cannot create checks, cancel checks, start Docker, or run PR code. API failures fail the plan instead of claiming that the pool is empty.Verification
pnpm build: passed, including host validation.pnpm check: passed (artifact freshness, validation, build, typecheck, diagnostics, unit, route and browser suites).