You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Verify (integration-1, Node 26) failed on b038e1a (run 36178852750) in host-session-pty.test.ts with expected 'ready\r\n' to match /24\s+80/u. The test polled until ready arrived, then asserted synchronously that the stty size line was already in the buffer. A PTY can deliver the two lines in separate chunks, so the assertion raced the second chunk.
The test now polls for ready followed by the size line.
pnpm test: unit 4296/4296, route-unit 91/91, projection 197/197, integration 1161/1165 with the PTY test passing. The 4 integration failures are Workbench Playwright timing assertions (audiobook-curator acceptance, examples-real host-test and worktree-proximity, streaming-render Suspense fallback). This change cannot reach them. The same tests failed in the local run for test(rstest): run the win32 rename mock test in an isolated pool #857 on a host at load average 120 to 180, and they pass in hosted CI.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verify (integration-1, Node 26)failed on b038e1a (run 36178852750) inhost-session-pty.test.tswithexpected 'ready\r\n' to match /24\s+80/u. The test polled untilreadyarrived, then asserted synchronously that thestty sizeline was already in the buffer. A PTY can deliver the two lines in separate chunks, so the assertion raced the second chunk.The test now polls for
readyfollowed by the size line.Verification
rstest --config rstest.integration.config.ts packages/agent-bundle/tests/host-session-pty.test.tspasses 3/3 runs.pnpm test: unit 4296/4296, route-unit 91/91, projection 197/197, integration 1161/1165 with the PTY test passing. The 4 integration failures are Workbench Playwright timing assertions (audiobook-curator acceptance, examples-real host-test and worktree-proximity, streaming-render Suspense fallback). This change cannot reach them. The same tests failed in the local run for test(rstest): run the win32 rename mock test in an isolated pool #857 on a host at load average 120 to 180, and they pass in hosted CI.