You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Nightly MCP conformance job has failed since #810 (run 36131421318 on 12a1ddc). #810 moved the route-harness fixture's tools to import { defineTool } from 'agent-bundle/routes'. The conformance harness copies that fixture to a temp directory and symlinks packages/agent-bundle/node_modules into it. That directory has no agent-bundle entry, because a package does not depend on itself, so Rspack failed with Can't resolve 'agent-bundle/routes'. In place, the fixture resolved it through the package's self-reference, which the temp copy loses.
The harness now links examples/host-test/node_modules. It links agent-bundle and resolves the same @agent-bundle/runtime, @modelcontextprotocol/server, react, and zod versions as before. dev-contract-project.ts already links an example's node_modules the same way.
Verification
Before the change, AGENT_BUNDLE_MCP_CONFORMANCE=1 rstest --config rstest.mcp-conformance.config.ts failed with the Nightly error. After it, the suite passes 1/1.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Nightly
MCP conformancejob has failed since #810 (run 36131421318 on 12a1ddc). #810 moved theroute-harnessfixture's tools toimport { defineTool } from 'agent-bundle/routes'. The conformance harness copies that fixture to a temp directory and symlinkspackages/agent-bundle/node_modulesinto it. That directory has noagent-bundleentry, because a package does not depend on itself, so Rspack failed withCan't resolve 'agent-bundle/routes'. In place, the fixture resolved it through the package's self-reference, which the temp copy loses.The harness now links
examples/host-test/node_modules. It linksagent-bundleand resolves the same@agent-bundle/runtime,@modelcontextprotocol/server,react, andzodversions as before.dev-contract-project.tsalready links an example'snode_modulesthe same way.Verification
AGENT_BUNDLE_MCP_CONFORMANCE=1 rstest --config rstest.mcp-conformance.config.tsfailed with the Nightly error. After it, the suite passes 1/1.pnpm lintpasses.pnpm teststopped in the unit pool on two 15 s timeouts (install.test.ts,web-host-routes-unit.test.ts) at load average 189. Neither file imports the conformance support module, and a rerun of both passes 70/70. The same unit pool passed in full on this host for test(rstest): run the win32 rename mock test in an isolated pool #857 and test(dev): wait for the PTY size line instead of asserting it after ready #858.