Repository navigation
fix: make workstation tuning conservative and verifiable - #11
Merged
Merged
Conversation
Limit automatic tuning to backed-up file-watch configuration. Preserve higher limits, verify effective values, and restore on failure. Document optional system changes and rollback separately. Co-authored-by: Codex <noreply@openai.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
SamuelIVX
marked this pull request as ready for review
October 13, 2026 03:25
SamuelIVX
added a commit
that referenced
this pull request
Oct 13, 2026
* fix: make rofi pickers handle selections correctly Preserve SSIDs and paths using indexed selections. Implement clipboard delete and confirmed clear, and keep cancellation side-effect free. Co-authored-by: Codex <noreply@openai.com> * fix: reserve clipboard deletion keys for picker actions Remove Delete from Rofi text editing before assigning the clipboard action. Add a regression check for conflicting bindings. Co-authored-by: Codex <noreply@openai.com> * fix: make workstation tuning conservative and verifiable (#11) Limit automatic tuning to backed-up file-watch configuration. Preserve higher limits, verify effective values, and restore on failure. Document optional system changes and rollback separately. Co-authored-by: Codex <noreply@openai.com> --------- Co-authored-by: Codex <noreply@openai.com>
SamuelIVX
added a commit
that referenced
this pull request
Oct 13, 2026
* fix: prevent duplicate wallpaper listeners Separate one-shot refresh from session-owned listening and bound daemon startup. Add isolated regression checks and CI. Co-authored-by: Codex <noreply@openai.com> * fix: report wallpaper workspace query failures Explicitly reject failed compositor queries while preserving event listening. Add a failed-query regression case. Co-authored-by: Codex <noreply@openai.com> * fix: make rofi pickers handle selections correctly (#10) * fix: make rofi pickers handle selections correctly Preserve SSIDs and paths using indexed selections. Implement clipboard delete and confirmed clear, and keep cancellation side-effect free. Co-authored-by: Codex <noreply@openai.com> * fix: reserve clipboard deletion keys for picker actions Remove Delete from Rofi text editing before assigning the clipboard action. Add a regression check for conflicting bindings. Co-authored-by: Codex <noreply@openai.com> * fix: make workstation tuning conservative and verifiable (#11) Limit automatic tuning to backed-up file-watch configuration. Preserve higher limits, verify effective values, and restore on failure. Document optional system changes and rollback separately. Co-authored-by: Codex <noreply@openai.com> --------- Co-authored-by: Codex <noreply@openai.com> --------- Co-authored-by: Codex <noreply@openai.com>
SamuelIVX
added a commit
that referenced
this pull request
Oct 13, 2026
* fix: prevent duplicate wallpaper listeners Separate one-shot refresh from session-owned listening and bound daemon startup. Add isolated regression checks and CI. Co-authored-by: Codex <noreply@openai.com> * fix: make rofi pickers handle selections correctly Preserve SSIDs and paths using indexed selections. Implement clipboard delete and confirmed clear, and keep cancellation side-effect free. Co-authored-by: Codex <noreply@openai.com> * fix: make workstation tuning conservative and verifiable Limit automatic tuning to backed-up file-watch configuration. Preserve higher limits, verify effective values, and restore on failure. Document optional system changes and rollback separately. Co-authored-by: Codex <noreply@openai.com> * feat: track portable shell and git customizations Install guarded developer fragments and migrate only recognized local settings. Preserve identity and local Git overrides; back up file and symlink conflicts with unique names. Co-authored-by: Codex <noreply@openai.com> * fix: reserve clipboard deletion keys for picker actions Remove Delete from Rofi text editing before assigning the clipboard action. Add a regression check for conflicting bindings. Co-authored-by: Codex <noreply@openai.com> * fix: report wallpaper workspace query failures Explicitly reject failed compositor queries while preserving event listening. Add a failed-query regression case. Co-authored-by: Codex <noreply@openai.com> * docs: establish verified workstation performance baselines (#13) Record isolated shell startup samples with explicit limitations. Document reproducible host checks and preserve visual settings until measured evidence justifies changes. Co-authored-by: Codex <noreply@openai.com> * fix: make rofi pickers handle selections correctly (#10) * fix: make rofi pickers handle selections correctly Preserve SSIDs and paths using indexed selections. Implement clipboard delete and confirmed clear, and keep cancellation side-effect free. Co-authored-by: Codex <noreply@openai.com> * fix: reserve clipboard deletion keys for picker actions Remove Delete from Rofi text editing before assigning the clipboard action. Add a regression check for conflicting bindings. Co-authored-by: Codex <noreply@openai.com> * fix: make workstation tuning conservative and verifiable (#11) Limit automatic tuning to backed-up file-watch configuration. Preserve higher limits, verify effective values, and restore on failure. Document optional system changes and rollback separately. Co-authored-by: Codex <noreply@openai.com> --------- Co-authored-by: Codex <noreply@openai.com> * fix: address workstation setup review findings Write Bash startup configuration atomically and preserve its mode. Canonicalize checkout paths, report missing installer prerequisites, and document supported Git versions and manual integration limits. Interleave measurement variants and strengthen regression coverage for failure paths and noninteractive loading. Co-authored-by: Codex <noreply@openai.com> --------- Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The root tuning script suppresses failures and reports complete success while disabling services and changing packages and power settings without verifying need or results.
Summary
Limit automation to a preserved, backed-up file-watch limit. Keep higher values, verify kernel state, and roll back failed application. Move power, services, DNF, codecs, and CLI installation to separately documented steps with checks and rollback. Existing host settings remain untouched.
Tests
Five isolated Python regression cases passed: higher limits, idempotent updates/backups, failed apply rollback, failed verification, and malformed configuration preservation. Full local suite and diff checks passed. No root writes were performed. CI passed regression tests and ShellCheck on the current head. CodeRabbit CLI review could not connect (WebSocket closed); required review remains incomplete.
Risks and rollback
Stacked on #10; merge preceding PRs and retarget to main. A small Python standard-library helper replaces broad automation. Backups are printed when changed; failed application restores config and attempts to restore the old kernel value. Never apply the script until the host review is complete.
Co-authored-by: Codex noreply@openai.com