Tests: fix the tests to check the new pattern#8719
Merged
Conversation
aborah-sudo
added
Waiting for review
Tests
Trivial
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the test_refresh_contain_timestamp test in test_kcm.py to match a change in log output. Specifically, it updates the grep command and the corresponding failure message to search for 'ldap_search_ext called:' instead of 'calling ldap_search_ext with'. I have no feedback to provide as there were no review comments to evaluate.
Contributor
|
The multihost tests are working with this change: |
spoore1
approved these changes
May 21, 2026
Contributor
spoore1
left a comment
spoore1
left a comment
There was a problem hiding this comment.
LGTM. See my other comment about tests passing. The check failures here are unrelated.
I got confirmation that this is simply a log change issue. We can fix the tests to check the new pattern. SSSD#8540 Reviewed-by: Scott Poore <spoore@redhat.com>
Contributor
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got confirmation that this is simply a log change issue. We can fix the tests to check the new pattern.
#8540