Skip to content

Updates to Enable ICARUS WireMod Closure #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gputnam wants to merge 10 commits into
base: release/SBN2025A
Choose a base branch
from
Open

Updates to Enable ICARUS WireMod Closure #911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
62a73b0
Addition of some WireMod diagnostic tools, addition of some flags (us…
francescopoppi Jun 30, 2026
bcc0d24
Merge development with release branch.
gputnam Jun 30, 2026
1560a43
Build fixes.
gputnam Jun 30, 2026
4ae2154
Change truth matching to use SimChannel's instead of SimEnergyDeposit's
gputnam Jul 1, 2026
1904b78
Add thxw resolution check to Diagnostic module.
gputnam Jul 1, 2026
6a7c821
Fix dummy hit finder config to match the nominal hit finder.
gputnam Jul 1, 2026
f636b16
Fix thXW calculation.
gputnam Jul 2, 2026
e1863b8
WireModHitDiagnostic: added some additional fields.
francescopoppi Jul 8, 2026
13291e8
Now the fixes to achieve closure are propagated to the production fcls
francescopoppi Jul 8, 2026
092ae11
this fixes corrects an issue with loss of precision in conversion fro…
francescopoppi Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 65 additions & 1 deletion icaruscode/WireMod/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
set(EXCLUDED_PLUGINS WireModMakeHists_plugin.cc ROICounter_module.cc HitComp_plugin.cc HitTTreeMaker_plugin.cc WireModifier_module.cc WireModifierXXW_module.cc)
set(EXCLUDED_PLUGINS WireModMakeHists_plugin.cc ROICounter_module.cc HitComp_plugin.cc HitTTreeMaker_plugin.cc WireModifier_module.cc WireModifierXXW_module.cc WireModHitDiagnostic_module.cc WireModScaleDebug_module.cc)

art_make(
LIB_LIBRARIES
Expand Down Expand Up @@ -241,6 +241,70 @@ simple_plugin(WireModifierXXW "module"
BASENAME_ONLY
)

simple_plugin(WireModHitDiagnostic "module"
${ART_FRAMEWORK_CORE}
${MF_MESSAGELOGGER}
${Boost_SYSTEM_LIBRARY}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
art_root_io::TFileService_service
lardataobj::AnalysisBase
lardataobj::RawData
lardataobj::RecoBase
lardata::RecoObjects
larreco::RecoAlg
${LARRECO_LIB}
${LARDATA_LIB}
${ART_FRAMEWORK_CORE}
${ART_FRAMEWORK_PRINCIPAL}
${ART_FRAMEWORK_SERVICES_REGISTRY}
${ART_FRAMEWORK_SERVICES_OPTIONAL}
${ART_FRAMEWORK_SERVICES_OPTIONAL_RANDOMNUMBERGENERATOR_SERVICE}
${ART_FRAMEWORK_SERVICES_OPTIONAL_TFILESERVICE_SERVICE}
${MF_MESSAGELOGGER}
${FHICLCPP}
${CLHEP}
${ROOT_GEOM}
${ROOT_XMLIO}
${ROOT_GDML}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
BASENAME_ONLY
)

simple_plugin(WireModScaleDebug "module"
${ART_FRAMEWORK_CORE}
${MF_MESSAGELOGGER}
${Boost_SYSTEM_LIBRARY}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
art_root_io::TFileService_service
lardataobj::AnalysisBase
lardataobj::RawData
lardataobj::RecoBase
lardata::RecoObjects
larreco::RecoAlg
${LARRECO_LIB}
${LARDATA_LIB}
${ART_FRAMEWORK_CORE}
${ART_FRAMEWORK_PRINCIPAL}
${ART_FRAMEWORK_SERVICES_REGISTRY}
${ART_FRAMEWORK_SERVICES_OPTIONAL}
${ART_FRAMEWORK_SERVICES_OPTIONAL_RANDOMNUMBERGENERATOR_SERVICE}
${ART_FRAMEWORK_SERVICES_OPTIONAL_TFILESERVICE_SERVICE}
${MF_MESSAGELOGGER}
${FHICLCPP}
${CLHEP}
${ROOT_GEOM}
${ROOT_XMLIO}
${ROOT_GDML}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
larcore::Geometry_Geometry_service
larcorealg::Geometry
BASENAME_ONLY
)

install_headers()
install_fhicl()
install_source()
Expand Down
53 changes: 53 additions & 0 deletions icaruscode/WireMod/WireModHitDiagnostic.fcl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
BEGIN_PROLOG

WireModHitDiag:
{
module_type: "WireModHitDiagnostic"

BeforeHitLabels: [
"dummyGaushit2dTPCEE",
"dummyGaushit2dTPCEW",
"dummyGaushit2dTPCWE",
"dummyGaushit2dTPCWW"
]

AfterHitLabels: [
"gaushit2dTPCEE",
"gaushit2dTPCEW",
"gaushit2dTPCWE",
"gaushit2dTPCWW"
]

ScaleInfoLabels: [
"WireModTPCEE",
"WireModTPCEW",
"WireModTPCWE",
"WireModTPCWW"
]

TrackLabels: [
"pandoraTrackGausCryoE",
"pandoraTrackGausCryoW"
]

DummyTrackLabels: [] # optional: Pandora on before-hits for PRE-WireMod reco theta

MatchWindowTicks: 10.0
OnlyMC: true
}

WireModROITree: {
SaveROITree: true
SaveTickHistograms: true
SavePerHitData: true
SaveByChannel: true
}

WireModPerHitData: {
SaveROITree: false
SaveTickHistograms: false
SavePerHitData: true
SaveByChannel: false
}

END_PROLOG
Loading