Updates to Enable ICARUS WireMod Closure#911
Open
gputnam wants to merge 10 commits into
Open
Conversation
…age of SignalROIF, rounding of floats, fixed scaling factors to 1 at al. )
Moved the TGraph2D interpolation to an option (UseGraph2DInterpolation), default is true. Renamed the fcls with _pops_ to _develop_ (bad practice on my local branch that got picked up) Added a fcl for null-wiremod modification. Added a fcl for the full diagnostic available in ntuples, including the modified ROIs.
…n channelROI to recob::Wire. There is a different approach which should be used in the future and can be tested with UseChannelROIMode: true, which Harry introduced to skip these conversions. UseChannelROIMode is ideal, but it was tested with a small sample, need higher stats check to verify that closure is achieved also in this way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.