Repository navigation
feat(engine): use the type menu's names in question text and step labels - #167
Merged
Merged
Conversation
…and flowlines as the Type menu does The question sentence, step labels and count messages now use the Type menu's nouns. SPARQL is unchanged; only the question-text snapshot moved. Closes #164 Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
|
🚅 Deployed to the explorer-app-pr-167 environment in sawgraph-explorer
1 service not affected by this PR
|
5 tasks
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The noun lives once on each entity module and feeds the question sentence, the step labels and the count messages.
Closes #164
Evidence
Before: each noun went red first with its old value still in place:
stepLabelsfailed 2 of 3 (samples),blockWording2 of 7 (streams), then the 2 new aquifer cases:After:
npm testpassed 594, skipped 11.query-shapes.txt(the SPARQL golden file) did not move; onlyquestion-text.txtwas re-recorded, and every line in its diff is a noun swap.npm run buildpassed.npm run lintshows the same 15 errors that were already there.The raw-type-name check in
stepLabelsnow removes each real label before it looks for type names, because "ground water aquifers" contains "aquifers". It still catches a bare "waterBodies" or "aquifers".Merge Danger
Door: two-way
Wording only. Reverting the three constants restores the old text.
Blast Radius: copy
npm run warm-cacheruns after deploy. NoDATA_VERSIONbump is needed: the answers are the same.engine/constants/prebuiltQueries.tsstill say "Samples".