Skip to content

Question text and step labels use the Type menu's names #164

Closed

Description

@prayaslashkari

This was generated by AI during triage.

Follow-up 1 from #70 (listed in the 2026-10-26 comment, never filed).

Agent Brief

Category: enhancement
Summary: The question sentence and pipeline step labels use the Type menu's names

Current behavior:
#70 renamed the Type menu entries (PR #83): "Sample Results", "Surface Water", "Ground Water (Aquifers)", with "Streams and Flowlines" under Feature Type. The generated Analysis Question sentence and the pipeline step labels still use the old nouns: "samples", "aquifers", "streams". Each entity module's label (the unfiltered plural noun on EntityModule) feeds both, so they agree with each other but not with the menu.

Desired behavior:
The unfiltered nouns read:

Entity type Now After
samples samples sample results
aquifers aquifers ground water aquifers
streams streams streams and flowlines
waterBodies, facilities, wells unchanged unchanged

Filtered wordings keep their current shape with the new noun where the noun appears (for example "streams and flowlines of 4 types"). An aquifer kind filter keeps its kind word before the noun.

Key interfaces:

  • EntityModule.label on each entity module: the one place the noun lives
  • The wording helpers that build the question sentence and step labels from it (namedOrCounted and the per-module block wording)

Acceptance criteria:

  • A samples question's sentence and step labels say "sample results"
  • An aquifers question says "ground water aquifers"; a streams question says "streams and flowlines"
  • The stepLabels rule test passes, and its expectations are updated where they name the old nouns
  • The SPARQL in the query-shape golden file is unchanged (only label text may move); read the diff after npx vitest run -u
  • Prebuilt dashboard question text that is generated from these nouns reads the same way

Out of scope:

  • Renaming entity types, AnalysisQuestion fields or anything in the cache key
  • Counts in dropdowns (separate issue), and querying water bodies and streams together (separate issue)

Activity

  1. prayaslashkari commented on Nov 17, 2026

    @prayaslashkari
    CollaboratorAuthor

    Done in #167, merged into development as 5a3919b. Question text, step labels and count messages now say "sample results", "ground water aquifers" and "streams and flowlines". Run npm run warm-cache after deploy so cached dashboard results pick up the new step names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestready-for-agentFully specified, ready for an AFK agent

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions