Skip to content

[Fix] Backup destinations lose missing parent directories #3700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roomote-roomote wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[Fix] Backup destinations lose missing parent directories #3700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60f8074
[Fix] Backup destinations lose missing parent directories
daniel-lxs Nov 12, 2026
f055f20
[Test] Run deployment path probes without inline shell commands
daniel-lxs Nov 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
166 changes: 164 additions & 2 deletions deploy/ci/deployment-scripts.test.mjs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 18 additions & 0 deletions deploy/ci/resolve-path-subprocess.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#!/usr/bin/env bash
set -euo pipefail

script_dir="$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd)"
source "$script_dir/../scripts/lib.sh"

case "$1" in
path)
resolved="$(abs_path "$2")"
printf '%s\n' "$resolved"
;;
state)
customer_state_dir "$2"
terraform_state_file "$2"
terraform_tfvars_file "$2"
;;
*) exit 1 ;;
esac
11 changes: 9 additions & 2 deletions deploy/scripts/lib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,15 @@ abs_path() {
fi

local dir
dir="$(cd -- "$(dirname -- "$path")" && pwd)"
printf '%s/%s\n' "$dir" "$(basename -- "$path")"
if dir="$(cd -- "$(dirname -- "$path")" 2>/dev/null && pwd)"; then
printf '%s/%s\n' "$dir" "$(basename -- "$path")"
else
# Output and state directories may have multiple not-yet-created parents.
case "$path" in
/*) printf '%s\n' "$path" ;;
*) printf '%s/%s\n' "$PWD" "$path" ;;
esac
fi
}

state_root() {
Expand Down
Loading