Repository navigation
[Fix] Backup destinations lose missing parent directories - #3700
Open
roomote-roomote[bot] wants to merge 2 commits into
Open
roomote-roomote[bot] wants to merge 2 commits into
roomote-roomote[bot] wants to merge 2 commits into
Conversation
Contributor
|
No new code issues found. Reviewed the positional-argument Bash runner and updated path probes. Deployment artifacts, fresh-host backup/restore, test, lint, and typecheck checks passed; Docker build and JavaScript/TypeScript CodeQL analysis were still running at review time. See session Reviewed f055f20 |
5 of 8 tasks
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
November 12, 2026 05:39
5 of 8 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Internal deployment-CLI correctness work; no separate issue.
Why this PR exists
What changed
Backup output paths with missing parents silently collapsed to a directory at the filesystem root. For example, a requested
/tmp/new-parent/backupsbecame/backups; an unprivileged operator then got a misleading permission failure, while a privileged operator could write into the wrong location.The shared deployment path helper now preserves an unresolved absolute path, or prefixes an unresolved relative path with the current directory. Existing directory/parent normalization is retained. Nested backup destinations and custom deployment-state roots stay where requested; option parsing does not create them. The change adds a small fallback to the existing helper, without dependencies, recursive resolution, remote backup changes or new options. Unresolved
..remains lexical rather than canonicalized.How it was tested
73fc55cc7with the new regressions and original helper: the native helper returns/backups; the actualroomote-deploy backupparser attempts/nested backupsand the disposable test safety guard refuses that outside-temp write (exit42). Both focused regressions fail for the expected reasons.f055f2005081064bceb44d7c120994e80171b0ce: identical native stimuli pass; requested relative/absolute nested directories contain the downloaded synthetic bundle. Existing directories/new leaves, spaces, trailing slash, dash-prefixed names, nested state/Terraform helpers and missing passphrase refusal are covered. Five deployment-script tests, Bash syntax, formatting/diff, precommit judgment and full normal pre-push gates pass. A checked-in positional-argument Bash runner replaces both inline shell snippets flagged by CodeQL on the first head; production path behavior is unchanged by that repair./bin/mkdirwithin the temporary cwd. This proves local path handling and file placement, not SSH authentication, encryption or remote container behavior. Fixtures are removed infinally. Browser proof is not applicable; no screenshots.pnpm deployment:validatepassed all seven native tests and six Compose-shape validations, then could not adapt Caddy configuration because this sandbox has no Docker daemon. Exact-head hosted Deployment artifacts, full tests, app build, CodeQL, upgrade and fresh-host backup/restore passed; automated re-review is clean. Both addressed CodeQL alert instances report fixed and their threads are resolved. Final metadata judgment is allowed to settle before ready-for-review delivery; normal human-review/protection gates remain.Related PRs
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locally (normal broad fast equivalents passed)pnpm changeset(bounded path correction)