Skip to content

[Docs] Match core configuration icons to the app - #3644

Open
roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/docs-settings-icon-parity-2tv9yavdwvsrj
Open

roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/docs-settings-icon-parity-2tv9yavdwvsrj

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

​Created by Roomote. View the session or mention @roomote-roomote for follow-up asks.

Related issue

Scheduled public-documentation product audit; no linked issue.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

Align four core configuration features with their existing app settings icons: Models uses Layers, Environments uses VectorSquare, Personal settings uses IdCard, and Skills uses GraduationCap. Update both the inference overview and its navigation group so they agree.

Why this change was made

The docs guidance requires matching app icons where available. These four docs features still used unrelated symbols despite current app settings defining explicit icons. The five-line change follows apps/web/src/components/settings/settings-navigation.ts and uses supported Lucide names.

Impact

Readers see the same configuration symbols in the dashboard and public docs. No prose, URLs, navigation ordering, or runtime behavior changes. Open #3594's provider-logo repairs are separate and are not duplicated.

How it was tested

  • mise exec -- pnpm --filter @roomote/docs build passed (the repository build script runs pinned Mintlify 4.2.650 build validation).
  • mise exec -- pnpm --filter @roomote/docs check passed: MDX/frontmatter validation and broken-link checks.
  • mise exec -- pnpm --filter @roomote/docs check-cookbook-index passed; all seven recipes are current, with no generated changes.
  • Supplementary structural audit: 122 MDX pages and 114 navigation leaf/root references; zero missing pages, titles, leaf icons, local icon assets, or duplicate navigation references. This is not a certification of every external link or behavior claim. A pre-existing invalid environment-routing fragment remains outside this icon-only diff.
  • Real Mintlify preview: rendered all four affected pages at desktop and mobile widths; inspected desktop Models group and configuration sidebar plus mobile configuration drawer. Opened and visually verified all six retained screenshots below. Independent proof review agrees with the stated scope; final diff matches the proof snapshot byte-for-byte.
  • git diff --check, pre-commit formatting/Judgement, and normal pre-push checks passed: oxlint, web/worker residual ESLint, 27 typecheck tasks, and Knip.
  • Full Vitest, formatting-inclusive pnpm lint / pnpm check-types, dark-theme captures, and external-provider workflows were not run for this five-line docs metadata change.

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset

No changeset is needed for documentation icon metadata.

Screenshots

Genuine local Mintlify rendering without mocks or modified DOM. These show representative page/sidebar appearance, not provider authorization or complete below-fold content. Existing missing third-party provider logos visible in desktop frames are covered by separate #3594. Mobile Models navigation and dark theme are not pictured.

Models overview and matching Layers navigation icon

Environments page and matching VectorSquare icon

Skills page and matching GraduationCap icon

Personal settings page and matching IdCard icon

Mobile configuration drawer with the three updated feature icons

Mobile inference overview layout

@roomote-community

roomote-community Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

No code issues found. See session

Reviewed all five icon metadata changes against the app settings navigation and docs guidance. All four icon names are valid Lucide identifiers, and the Models group and page remain consistent. Current-head docs validation, lint, typecheck, tests, and Knip checks passed; Docker build and JavaScript/TypeScript CodeQL analysis were still running when checked. No local validation suites were rerun.

Reviewed 5058d00

@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review November 2, 2026 14:16

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant