Repository navigation
[Docs] Match core configuration icons to the app - #3644
Open
roomote-roomote[bot] wants to merge 1 commit into
Open
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
|
No code issues found. See session Reviewed all five icon metadata changes against the app settings navigation and docs guidance. All four icon names are valid Lucide identifiers, and the Models group and page remain consistent. Current-head docs validation, lint, typecheck, tests, and Knip checks passed; Docker build and JavaScript/TypeScript CodeQL analysis were still running when checked. No local validation suites were rerun. Reviewed 5058d00 |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
November 2, 2026 14:16
5 of 8 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Scheduled public-documentation product audit; no linked issue.
Why this PR exists
What changed
Align four core configuration features with their existing app settings icons: Models uses Layers, Environments uses VectorSquare, Personal settings uses IdCard, and Skills uses GraduationCap. Update both the inference overview and its navigation group so they agree.
Why this change was made
The docs guidance requires matching app icons where available. These four docs features still used unrelated symbols despite current app settings defining explicit icons. The five-line change follows
apps/web/src/components/settings/settings-navigation.tsand uses supported Lucide names.Impact
Readers see the same configuration symbols in the dashboard and public docs. No prose, URLs, navigation ordering, or runtime behavior changes. Open #3594's provider-logo repairs are separate and are not duplicated.
How it was tested
mise exec -- pnpm --filter @roomote/docs buildpassed (the repository build script runs pinned Mintlify 4.2.650 build validation).mise exec -- pnpm --filter @roomote/docs checkpassed: MDX/frontmatter validation and broken-link checks.mise exec -- pnpm --filter @roomote/docs check-cookbook-indexpassed; all seven recipes are current, with no generated changes.git diff --check, pre-commit formatting/Judgement, and normal pre-push checks passed: oxlint, web/worker residual ESLint, 27 typecheck tasks, and Knip.pnpm lint/pnpm check-types, dark-theme captures, and external-provider workflows were not run for this five-line docs metadata change.Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changesetNo changeset is needed for documentation icon metadata.
Screenshots
Genuine local Mintlify rendering without mocks or modified DOM. These show representative page/sidebar appearance, not provider authorization or complete below-fold content. Existing missing third-party provider logos visible in desktop frames are covered by separate #3594. Mobile Models navigation and dark theme are not pictured.