Update firebase-childrenkeys to 3.0.0 (removing axios dependency)#51
Conversation
|
@codex review Triggered automatically because this PR was opened ready for review or was marked ready for review. |
pkaminski
left a comment
pkaminski
left a comment
There was a problem hiding this comment.
@pkaminski reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on snoack).
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ca77f72d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "dependencies": { | ||
| "firebase-admin": "10.x || 11.x || 12.x || 13.x", | ||
| "firebase-childrenkeys": "^2.3.5", | ||
| "firebase-childrenkeys": "^3.0.0", |
There was a problem hiding this comment.
After bumping firebase-childrenkeys to ^3.0.0, the lockfile was not updated and still resolves only firebase-childrenkeys@npm:^2.3.5 (to 2.6.2). In Yarn 4, CI installs commonly run with immutable lockfiles, so this mismatch can either fail installs (--immutable / default-on-CI behavior) or keep testing against the old dependency version, meaning this PR does not reliably deliver the intended v3 migration.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Yes, I'm waiting for firebase-childrenkeys 3.0.0 to be released, then I'll update the PR.
snoack
left a comment
snoack
left a comment
There was a problem hiding this comment.
@snoack made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on snoack).
| "dependencies": { | ||
| "firebase-admin": "10.x || 11.x || 12.x || 13.x", | ||
| "firebase-childrenkeys": "^2.3.5", | ||
| "firebase-childrenkeys": "^3.0.0", |
There was a problem hiding this comment.
Yes, I'm waiting for firebase-childrenkeys 3.0.0 to be released, then I'll update the PR.
snoack
force-pushed
the
childrenkeys-no-axios
branch
from
1ca77f7 to
f374416
Compare
snoack
left a comment
snoack
left a comment
There was a problem hiding this comment.
@snoack resolved 1 discussion.
Reviewable status:
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
pkaminski
left a comment
pkaminski
left a comment
There was a problem hiding this comment.
@pkaminski reviewed 1 file and all commit messages.
Reviewable status:
2 participants
This change is