Remove axios dependency

[snoack]

This change is 

[pkaminski]

@codex review

Triggered automatically because this PR was opened ready for review or was marked ready for review.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm-check-updates@​20.0.0 ⏵ 20.0.2	+1		+1	+1

View full report

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: db00f6e263

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Restore custom agent support for REST requests

The switch from axios.get(..., { agent }) to fetch(url) drops the transport override path entirely, so callers that pass options.agent (for proxies, custom CA trust, or mTLS) now have that option silently ignored and requests can fail in those environments. This is a functional regression introduced by this commit; please wire options.agent into the fetch call (e.g., via a compatible dispatcher) or explicitly reject the option so failures are not silent.

Useful? React with 👍 / 👎.

[snoack]

@snoack made 1 comment.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions.

---

package.json line 3 at r1 (raw file):

{
  "name": "firebase-childrenkeys",
  "version": "3.0.0",

Whether this should be a major version bump is debatable:

1. Dropping the agent option is essentially no-op because axios ignored the agent config key (but expected httpAgent/httpsAgent instead).
2. Node 18 was already required previously since it is required by firebase-admin >=12, the engines.node value was merely stale.
3. The shape of network/HTTP errors changed but it seems hubkit and reviewable-server don't need to be adapted for that, though one could argue that this is technically a breaking change.

[snoack]

@snoack resolved 1 discussion.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion.

[pkaminski]

@pkaminski reviewed 3 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on snoack).

---

package.json line 3 at r1 (raw file):

Previously, snoack (Sebastian Noack) wrote…

Whether this should be a major version bump is debatable:

1. Dropping the agent option is essentially no-op because axios ignored the agent config key (but expected httpAgent/httpsAgent instead).
2. Node 18 was already required previously since it is required by firebase-admin >=12, the engines.node value was merely stale.
3. The shape of network/HTTP errors changed but it seems hubkit and reviewable-server don't need to be adapted for that, though one could argue that this is technically a breaking change.

I don't think it's a big deal either way, might as well keep it as major.

[snoack]

@snoack made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on snoack).

---

package.json line 3 at r1 (raw file):

Previously, pkaminski (Piotr Kaminski) wrote…

I don't think it's a big deal either way, might as well keep it as major.

No strong preference either, but I suppose what ever we decide here also extends to Reviewable/nodefire#51.

[pkaminski]

@pkaminski made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on snoack).

---

package.json line 3 at r1 (raw file):

Previously, snoack (Sebastian Noack) wrote…

No strong preference either, but I suppose what ever we decide here also extends to Reviewable/nodefire#51.

When in doubt bump the major, I say.