Check BIOS assets selected by the setup recipe - #331
Merged
mstan merged 2 commits intoSep 7, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A retail-only SDK currently fails staging when unused OpenBIOS files are absent. Read the staged
game.tomland require its selected BIOS profile. OpenBIOS-enabled recipes still require the OpenBIOS profile, image and license. Reject a missing recipe, missing selected profile or profile outside the staged kit.Ten source-owned synthetic tests cover the policy. The unchanged shell gate rejects a retail-only fixture for missing OpenBIOS; the checker passes the corrected fixture and rejects the negative controls. Run
python runtime/tests/test_setup_bios_assets.py.Fork review exposed a containment gap in default/OpenBIOS paths. Resolve every required path in the common gate before checking that it stays inside the kit. Six external file/directory symlink assertions fail before this correction; all ten tests pass afterward, with no symlink skips on the native Windows test host. Internal symlinks remain supported. The complete SDK stage, owned generation and runtime suite were repeated after this correction. The runtime source and generated bytes remain identical, so the exact previously built game executable is reused for the fresh isolated startup/normal-close check.
The complete
stage_setup_sdk.shalso passed with an actual retail-only SCPH1001 SDK and no OpenBIOS assets. The resulting SDK verified an owned disc, generated game and BIOS code, and built the native runtime. Emitters used documentedPSXRECOMP_STATIC_CLI=ONto avoid unrelated ambient MinGW DLL selection.This changes asset validation only. Current upstream's retail CLI generation still selects SCPH1001. Accepting an explicit SCPH5552 profile at the asset gate does not establish full SCPH5552 CLI support; that integration, including existing #243, remains separate. No retail BIOS is added to source or redistributed.
Validation and limits
8d56cf659fd84367c3f778e17851674ac7896371; review head:406451cb92da4d9f701c81b8271e420cef8677cc.474ec448d1fa040f21f121a99695ede07cfc362d893305813419269b535b70d5. This is bounded startup and normal shutdown, not gameplay completion or listening acceptance. Audio used SDL dummy output. No native Linux/macOS game route is claimed.dirty_text_continuation_guards,aot_overlay_discovery,release_zip) and three disabled tests. This branch does not change that recompiler source. Those baseline failures are not reported as passes.Scope and fork review
Fork review #24 inspected this exact head against immutable
review-base/mstan-8d56cf659fd8. Cubic found no remaining issues on the exact head (review IDs: 5133120825). The initial file/directory symlink findings were valid and fixed in the common asset check; both threads are resolved after failing-before/passing-after tests and repeated staging/runtime/owned-route validation. The public PR branch points to the same commit. Upstream master was fetched again and remains the recorded base. This contribution contains 2 commit(s) and 5 changed files.docs/SETUP_BIOS_ASSETS.md: behavior and verification documentation.runtime/CMakeLists.txt: source-owned regression and test registration.runtime/tests/test_setup_bios_assets.py: source-owned regression and test registration.tools/check_setup_bios_assets.py: bounded correction.tools/stage_setup_sdk.sh: bounded correction.Developed with AI assistance; validated as described (test evidence in PR body). AI writes the code and the PR, but I always test before I send something up. Happy to iterate on this process with your feedback.