Restore C11 labels and C declaration ownership - #330
Merged
mstan merged 1 commit intoSep 7, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 9 rejects the local declaration immediately after
retry_candidates:inoverlay_loader.c. Add the required null statement. It then reaches linking and exposes two local C++ declarations offntrace_is_game_started; remove those duplicate declarations so the existingfntrace.hC declaration owns the linkage.Two source-owned checks cover the actual label/declaration excerpt under
-std=c11 -pedantic-errorsand the header-owned declaration. They fail on the unchanged source and pass on this branch. They are registered in CTest.Native Linux GCC 9 full-runtime controls:
fntrace_is_game_started(), independently demonstrating the second correction.The CI workflow is on a separate build-only branch and is not part of this contribution.
Validation and limits
8d56cf659fd84367c3f778e17851674ac7896371; review head:d8725466bcbae7b235f33a6d334bfd455e39e7f6.ebf755b918c52d9625e08aedb31e3b6d4baaeebbbdfe6022d5a573257e46fe67. This is bounded startup and normal shutdown, not gameplay completion or listening acceptance. Audio used SDL dummy output. No native Linux/macOS game route is claimed.dirty_text_continuation_guards,aot_overlay_discovery,release_zip) and three disabled tests. This branch does not change that recompiler source. Those baseline failures are not reported as passes.Scope and fork review
Fork review #26 inspected this exact head against immutable
review-base/mstan-8d56cf659fd8. Cubic reported no issues on the exact head (review IDs: 5132944873); no unresolved findings remain. The public PR branch points to the same commit. Upstream master was fetched again and remains the recorded base. This contribution contains 1 commit and 6 changed files.docs/C11_SOURCE_COMPATIBILITY.md: behavior and verification documentation.runtime/CMakeLists.txt: source-owned regression and test registration.runtime/src/main.cpp: bounded correction.runtime/src/overlay_loader.c: bounded correction.runtime/tests/test_fntrace_c_linkage.py: source-owned regression and test registration.runtime/tests/test_overlay_retry_c11.py: source-owned regression and test registration.Developed with AI assistance; validated as described (test evidence in PR body). AI writes the code and the PR, but I always test before I send something up. Happy to iterate on this process with your feedback.