Skip to content

Regenerate protobuf code. #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hbarthels merged 1 commit into from
Jun 3, 2026
Merged

Regenerate protobuf code. #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
128 changes: 64 additions & 64 deletions sdks/go/src/lqp/v1/transactions.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions sdks/julia/LogicalQueryProtocol.jl/src/gen/relationalai/lqp/v1/transactions_pb.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ struct ExportIcebergConfig
table_properties::Dict{String,String}
end
ExportIcebergConfig(;locator = nothing, config = nothing, table_def = nothing, prefix = "", target_file_size_bytes = zero(Int64), compression = "", table_properties = Dict{String,String}()) = ExportIcebergConfig(locator, config, table_def, prefix, target_file_size_bytes, compression, table_properties)
PB.reserved_fields(::Type{ExportIcebergConfig}) = (names = String[], numbers = Union{Int,UnitRange{Int}}[4])
Copy link
Copy Markdown
Contributor

@minsungc minsungc Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why just this .reserved_fields was missing 🤔 it seems to be present everywhere else, and the head of the PB file doesn't indicate a version bump.

Copy link
Copy Markdown
Contributor Author

@hbarthels hbarthels Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good question. I have no idea. I will try to find that out.

Copy link
Copy Markdown
Contributor Author

@hbarthels hbarthels Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude thinks that this must have been a mistake on a previous PR. Perhaps some of the code was produced "manually" and was incomplete.

PB.default_values(::Type{ExportIcebergConfig}) = (;locator = nothing, config = nothing, table_def = nothing, prefix = "", target_file_size_bytes = zero(Int64), compression = "", table_properties = Dict{String,String}())
PB.field_numbers(::Type{ExportIcebergConfig}) = (;locator = 1, config = 2, table_def = 3, prefix = 5, target_file_size_bytes = 6, compression = 7, table_properties = 8)

Expand Down
6 changes: 3 additions & 3 deletions sdks/python/src/lqp/proto/v1/fragments_pb2.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ from typing import ClassVar as _ClassVar, Optional as _Optional, Union as _Union
DESCRIPTOR: _descriptor.FileDescriptor

class Fragment(_message.Message):
__slots__ = ()
__slots__ = ("id", "declarations", "debug_info")
ID_FIELD_NUMBER: _ClassVar[int]
DECLARATIONS_FIELD_NUMBER: _ClassVar[int]
DEBUG_INFO_FIELD_NUMBER: _ClassVar[int]
Expand All @@ -18,15 +18,15 @@ class Fragment(_message.Message):
def __init__(self, id: _Optional[_Union[FragmentId, _Mapping]] = ..., declarations: _Optional[_Iterable[_Union[_logic_pb2.Declaration, _Mapping]]] = ..., debug_info: _Optional[_Union[DebugInfo, _Mapping]] = ...) -> None: ...

class DebugInfo(_message.Message):
__slots__ = ()
__slots__ = ("ids", "orig_names")
IDS_FIELD_NUMBER: _ClassVar[int]
ORIG_NAMES_FIELD_NUMBER: _ClassVar[int]
ids: _containers.RepeatedCompositeFieldContainer[_logic_pb2.RelationId]
orig_names: _containers.RepeatedScalarFieldContainer[str]
def __init__(self, ids: _Optional[_Iterable[_Union[_logic_pb2.RelationId, _Mapping]]] = ..., orig_names: _Optional[_Iterable[str]] = ...) -> None: ...

class FragmentId(_message.Message):
__slots__ = ()
__slots__ = ("id",)
ID_FIELD_NUMBER: _ClassVar[int]
id: bytes
def __init__(self, id: _Optional[bytes] = ...) -> None: ...
Loading
Loading