Regenerate protobuf code.#254
Merged
Merged
Conversation
minsungc
reviewed
Jun 3, 2026
| table_properties::Dict{String,String} | ||
| end | ||
| ExportIcebergConfig(;locator = nothing, config = nothing, table_def = nothing, prefix = "", target_file_size_bytes = zero(Int64), compression = "", table_properties = Dict{String,String}()) = ExportIcebergConfig(locator, config, table_def, prefix, target_file_size_bytes, compression, table_properties) | ||
| PB.reserved_fields(::Type{ExportIcebergConfig}) = (names = String[], numbers = Union{Int,UnitRange{Int}}[4]) |
Contributor
There was a problem hiding this comment.
I wonder why just this .reserved_fields was missing 🤔 it seems to be present everywhere else, and the head of the PB file doesn't indicate a version bump.
Contributor
Author
There was a problem hiding this comment.
That's a good question. I have no idea. I will try to find that out.
Contributor
Author
There was a problem hiding this comment.
Claude thinks that this must have been a mistake on a previous PR. Perhaps some of the code was produced "manually" and was incomplete.
minsungc
approved these changes
Jun 3, 2026
Contributor
minsungc
left a comment
minsungc
left a comment
There was a problem hiding this comment.
Clarifying question from me, but otherwise looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the result of running
make protobufon current main.