fix(deps): bump lodash to 4.18.1 in vulnerability-frontend [foreman-3.16]#2570
Open
Odilhao wants to merge 1 commit into
Open
fix(deps): bump lodash to 4.18.1 in vulnerability-frontend [foreman-3.16]#2570Odilhao wants to merge 1 commit into
Odilhao wants to merge 1 commit into
Conversation
Closes CVE-2025-13465, CVE-2026-4800 in vulnerability-frontend.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideBumps the transitive lodash dependency to 4.18.1 in vulnerability-frontend by adding an override in package.json and updating the lockfile; no runtime/application logic changes were made. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This was referenced Apr 22, 2026
Author
|
Master branch fix: #2568 · Other backport: foreman-3.18 #2569 |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The override for lodash is set to "^4.18.0" while the description states you’re specifically targeting 4.18.1; consider pinning to "4.18.1" (or a narrower range) to ensure the security fix and avoid pulling in unexpected future minors.
- Consider scoping the lodash override to only the dependency paths that actually require it (rather than a top-level global override) to reduce the risk of unintended version conflicts with other packages depending on lodash.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The override for lodash is set to "^4.18.0" while the description states you’re specifically targeting 4.18.1; consider pinning to "4.18.1" (or a narrower range) to ensure the security fix and avoid pulling in unexpected future minors.
- Consider scoping the lodash override to only the dependency paths that actually require it (rather than a top-level global override) to reduce the risk of unintended version conflicts with other packages depending on lodash.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Author
|
Thanks for the review! To clarify: lodash 4.18.1 is published on npm — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
lodash(transitive dependency) invulnerability-frontendto resolve 2 security CVEs.All changes are confined to dependency lockfiles and the
overridessection ofpackage.json; no application logic was modified.CVEs addressed
Changes
package.json^4.18.0package-lock.jsonlodashfrom4.17.21to4.18.1Testing
References
_.unsetand_.omitfunctionsSummary by Sourcery
Bump lodash dependency in vulnerability-frontend to address reported security vulnerabilities.
Build:
Chores: