fix(deps): bump lodash to 4.18.1 in vulnerability-frontend [foreman-3.18]#2569
fix(deps): bump lodash to 4.18.1 in vulnerability-frontend [foreman-3.18]#2569Odilhao wants to merge 1 commit into
Conversation
Closes CVE-2025-13465, CVE-2026-4800 in vulnerability-frontend.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideDependency-only security update that pins the transitive lodash version for vulnerability-frontend via package.json overrides and corresponding lockfile changes; no application code or behavior is intentionally altered. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Master branch fix: #2568 · Other backport: foreman-3.16 #2570 |
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Consider tightening the lodash override to the exact patched version used in the lockfile (e.g. "4.18.1" instead of "^4.18.0") so that future minor/patch releases don’t silently change the resolved version for this security-sensitive dependency.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider tightening the lodash override to the exact patched version used in the lockfile (e.g. "4.18.1" instead of "^4.18.0") so that future minor/patch releases don’t silently change the resolved version for this security-sensitive dependency.
## Individual Comments
### Comment 1
<location path="package.json" line_range="43" />
<code_context>
"react": "^18.2.0"
- }
+ },
+ "lodash": "^4.18.0"
},
"sassIncludes": {
</code_context>
<issue_to_address>
**issue (bug_risk):** The overridden lodash version ^4.18.0 does not appear to be a published version and may break installs.
Lodash’s latest stable release is 4.17.21; 4.18.0 is not published on npm, so this override will cause `npm install` to fail. If you’re enforcing a minimum secure version, update this to `^4.17.21` (or another actually published secure version).
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| "react": "^18.2.0" | ||
| } | ||
| }, | ||
| "lodash": "^4.18.0" |
There was a problem hiding this comment.
issue (bug_risk): The overridden lodash version ^4.18.0 does not appear to be a published version and may break installs.
Lodash’s latest stable release is 4.17.21; 4.18.0 is not published on npm, so this override will cause npm install to fail. If you’re enforcing a minimum secure version, update this to ^4.17.21 (or another actually published secure version).
|
Thanks for the review! To clarify: lodash 4.18.1 is published on npm — |
Summary
Bumps
lodash(transitive dependency) invulnerability-frontendto resolve 2 security CVEs.All changes are confined to dependency lockfiles and the
overridessection ofpackage.json; no application logic was modified.CVEs addressed
Changes
package.json^4.18.0package-lock.jsonlodashfrom4.17.21to4.18.1Testing
References
_.unsetand_.omitfunctionsSummary by Sourcery
Bug Fixes: