Skip to content

fix: complete isolated validation and document proxy recovery - #48

Merged
Nickfost merged 3 commits into
mainfrom
docs/proxy-spool-recovery-guidance
Nov 7, 2026
Merged

Nickfost merged 3 commits into
mainfrom
docs/proxy-spool-recovery-guidance

Conversation

@Nickfost

@Nickfost Nickfost commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Git initialization copied optional hooks into every isolated seed and stage. Explicit git init --template= removes that repeated work while preserving complete Git manifests, identity/history checks, tamper checks, isolation and cleanup. The driver and optional workflow now select merged executor c51844cf05f7a9f647322f4b7cbbb6379f40ad5d, whose strict completion receipt addresses the earlier missing-receipt failure.

The guidance also explains disk-backed proxy spooling and the ordered source, artifact, template, private-adopter, installation and live-availability gates. The 128 MiB memory limit, 1 GiB body cap and two upload slots remain unchanged.

Exact source 9ce1e35d6bac8d7a7b5f4af9a49f39c91125219b, tree 18a1e6c9e8a30c7981a0247501151fa112d0e93a, base da9e34ef5ccce4b0c48ffa0d18440ee7451cf963. Direct independent source review approved the successor with no findings, receipt SHA256 9aa1130963012b247c5249342ce528902860ae60a7a1fb101d1a9258df52bbef, reusing the unchanged b1ca13d review. This is technical source review; no human GitHub review or unavailable bot approval is claimed.

Validation:

  • Complete normal upstream validation passed all 11 stages in a reported 485 seconds.
  • Genuine initialized-adopter source 3413f5afb4014d3e01900262827d4a19e7b69956, with an explicit zero prior-state base, passed all 11 stages in 445 seconds. Both runs used the exact reviewed suite and merged c51844c policy/executor from separate checkouts.
  • Each run executed all 51 harness cases, six executor-binding cases, 18 candidate-runner cases and 14 required workflow cases. The 51-case runs took 122.470 and 121.007 seconds. Public and candidate policy/updater/release inventories matched the committed suite. Expected and actual skips were empty. Original 180-second command limits and 60-second cleanup grace were preserved.
  • One 235,520-byte archive, SHA256 ff7174e499c97821b97529421dd583a985d9828540974f60785bba46fc54e30d, was exported. All 38 file hashes/sizes, 22 stage-log hashes, report identities and required planned inventories verified at receipt. Scoped cleanup, baseline-executor restoration and final isolated-worker admission passed. Closed receipt SHA256 c1fce10bb89598fc12a54ea70ff01b64935935725c9861861bb84b85b229f1af.
  • Existing local workflow, documentation, policy, history and whitespace controls remain valid. Optional hosted checks were skipped and supply no suite acceptance. Earlier timeouts and missing-receipt failures remain failed and preserved.

Documentation impact: docs/LOCAL-VALIDATION.md explains empty-template seeds and matching merged-executor setup. README.md, AGENTS.md and docs/UPDATING.md describe spool-memory recovery and separate adoption/availability gates. No visual change. Ordinary-CI 840 and independent deployer 689 pins, image policy and immutable release records remain unchanged.

Private adoption, live-worker installation/recovery, image promotion, storage/retention changes, application CI release, a new template release/tag and deployment remain separate. Issue #32 retains its operational signing, recovery and acceptance-policy migration gates.

Closes #47.

Prepared by GPT-6.1 Sol through Codex in T3 Code. Source review came from the existing independent MASTER route.

@Nickfost

Nickfost commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

APPROVED. Independent source and documentation review of PR48, exact head 4f7bb8e90aed4e0ec2c384f75d0479558f1f2e36 against base da9e34ef5ccce4b0c48ffa0d18440ee7451cf963, found no blocking findings.

Reviewer: the existing MASTER coordinator, Codex gpt-6.1-sol, performing the review directly and independently of the guidance implementation owner. I authored none of this candidate and made no repository edits. This is the already-established manual review route while GitHub Codex review quota is unavailable. No automatic Codex completion, Bugbot approval, new reviewer or delegate is claimed.

The candidate tree is 564468cab38187f3521b0465a459e9cd1943c9d8. SHA-256 of the full-index binary diff from the exact base to this head is 0077aa44f0a71cf9d49a12d8223f78190d3e83c53559822f8dec53b5ff9db7e2, matching the retained source.patch. I independently verified the single parent, clean worktree and published PR head/base. The complete change is 66 inserted lines in docs/UPDATING.md, README.md and AGENTS.md. Every other tracked tree entry, including executable, harness, policy, schema, configuration, workflow, corpus, runtime/image pin and TEMPLATE_RELEASE files, is identical to the base.

Scope reviewed:

  • The complete three-file diff and issue docs: explain bounded proxy spool memory and safe adoption #47, compared with immutable engine 1c685dacc109597641fd13dfae48606e76f73ee7's maintenance contract and proxy source. Disk-backed temporary spools, synchronization and cache release in 4 MiB windows, tmpfs/ramfs refusal and the unchanged 128 MiB memory, 1 GiB body and two shared upload-slot limits are described accurately.
  • Ordered acceptance of engine source, actual template guidance, immutable private guidance import, complete repeated controller/runner artifacts, separately authorized host adoption and independent live availability. The unpublished-revision link resolves to the procedure that preserves adopter ownership and TEMPLATE_RELEASE; the managed-image guide supplies original config-digest and runtime-ID distinctions and complete clean-repeat requirements.
  • Actual-predecessor staging, incumbent images/checkpoints, disk admission, workload protections, installer/proxy locks and current-boot uncertainty guards. The guidance does not select the new engine, alter the 840 compatibility baseline, authorize storage/capacity changes or release a held application retry.
  • Failed/incomplete build handling and incident-cause limits. The retained phase1 closure records three verified archives and no second controller image. This guidance correctly leaves complete artifact acceptance open and does not turn engine source acceptance, a running container, a restart or an isolated health response into live recovery. EOF, endpoint failure and timeout alone do not establish a cause.

Independent checks passed: exact tree-entry comparison, one-parent identity, source-patch equality, git diff --check, and all 76 relative file/anchor links across the ten tracked Markdown files. The check receipt is /opt/t3code/userdata/artifacts/project-status/manual-independent-review-template48-4f7bb8e-checks-20261103.json.

Documentation impact is complete for this bounded guidance change. UPDATING contains the procedure and caveats, with consistent README and AGENTS pointers. No missing or inaccurate documentation finding was identified. There is no visual application change requiring screenshots.

No unresolved blocking findings were identified, and GitHub showed no review threads at this check. This affirmative approval covers only exact 4f7bb8e90aed4e0ec2c384f75d0479558f1f2e36. A changed head requires fresh review. Complete upstream and genuine initialized-adopter suites remain pending before normal merge. This review does not execute those suites or establish image-packet, private-runtime or live-host acceptance. Existing ownership and operational holds remain intact.

Nickfost commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

The separately authorized single timing diagnostic is complete as a failed/incomplete measurement, not normal suite acceptance. It used frozen source 4f7bb8e90aed4e0ec2c384f75d0479558f1f2e36, base da9e34ef5ccce4b0c48ffa0d18440ee7451cf963, engine policy 840fb9be8a1c69404a5eebcf17855eff13c6c928, and the reviewed external adapter with the original 180-second command deadline and 60-second cleanup grace. No retry was run.

45 cases completed and passed. Case 46, test_unexpected_skip_fails_instead_of_claiming_full_coverage, was running at timeout. Four cases never started. There was no normal completion summary. Source and suite bytes remained unchanged. All eight available export files and archive SHA-256 90299e86488efafb08eb594ab2c78f36d161b56d23c6a5e50c0ffa1ba541b4c4 were verified, then scoped cleanup and final isolated-worker admission passed.

The longest completed cases were checkout substitution, 24.404 seconds; Actions-state plan invariance, 23.372 seconds; paired failure/timeout/cancellation logs, 19.801 seconds; and trusted upstream/derived plan ownership, 15.324 seconds. These measure whole cases including setup/teardown and instrumentation. They do not isolate a removable operation, establish a host cause or promise an optimization saving.

A source-only follow-up proposal considers disabling optional default Git initialization templates for orchestrator-owned seeds while preserving complete identity/history/metadata/tamper coverage and every test. That proposal is unimplemented and needs an explicit source extension, exact-head review and normal complete acceptance. No test or deadline was relaxed.

The prior full upstream failure remains binding. No initialized-adopter acceptance, template merge or private guidance import occurred. Documentation impact of this external diagnostic is recorded here; no repository source or documentation changed. Image/live recovery and application retries remain separate holds.

@Nickfost Nickfost changed the title docs: explain proxy upload memory recovery gates fix: omit optional Git seed templates and document proxy recovery Nov 5, 2026

Nickfost commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

Independent MASTER source review approves exact head b1ca13d07979330ca609741e53a699921fcff6f5, tree 60c61ab3b64df07c2a48965c3465bfde2ae7cb3e, against base da9e34ef5ccce4b0c48ffa0d18440ee7451cf963. No findings.

Reviewed the --template= change, its regression, all shared clone callers, seed/stage manifest checks and the documentation update. Reused the unchanged accepted 4f7bb8e review. Independently confirmed all 50 prior test IDs and bodies are unchanged, with one new regression, exact patch identity and a clean worktree.

No tests or guest operations were run by this reviewer. The producer retained the failing-before and two passing-after local controls. Complete exact-source upstream and initialized-adopter acceptance remains required before normal merge under the existing full-send authority. This source verdict establishes no live worker recovery.

Posted by GPT-6.1 Sol through Codex on Nickfost's behalf; the independent MASTER supplied the review above.

@Nickfost

Nickfost commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

The source-matched image-production prerequisite now has a complete successor from merged engine 4c30089f2476e4cb7d8a8659845bd76d0dd714b7, tree e8da173b6e04b260d48630a7dfe870728c6c8788. Two separate clean builders each produced the controller and runner with the pinned Buildx/BuildKit, --no-cache, and unchanged source inputs. Both controller Go suites passed.

Role Original config digest C, matching both repetitions
Controller sha256:f01badb82f05e398bcceed39c975bfd6c1966161187d2dcf7ddc7ad6baab9a79
Runner sha256:a0a697737e5606f5a1ed6e8fa8f7c9ad72b3dce0c5b66d5a892e92e0ea3b3ae5

All four complete archives were exported, hash-verified, and re-proved at the destination against the original descriptors and layer closure. The 904,560,640-byte evidence bundle has SHA256 3e430c69947fc5ea977f1f3cd98235358c6a5584c088acfee2050b6d69aeb269; its 39 recorded files include cleanup and final disposable-worker admission. Both owned builders were removed and the incumbent executor/protected image identities were preserved. The earlier incomplete 1c685da packet remains failed and unchanged.

This completes producer-side artifact evidence and is submitted to the existing independent artifact gate. It does not establish private image policy, installation or live worker recovery. PR48 still needs the separately tracked executor correction in engine PR165, a merged executor pin, and complete normal upstream and initialized-adopter validation. No application retry or live hold is released.

Agent note: GPT-6.1 Sol through Codex, reporting on Nick's behalf.

@Nickfost

Nickfost commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

Independent MASTER artifact review approves the complete Linux/amd64 two-clean-pair bundle for source 4c30089f2476e4cb7d8a8659845bd76d0dd714b7, tree e8da173b6e04b260d48630a7dfe870728c6c8788. No findings.

Verified the904560640-byte bundle SHA256 3e430c69947fc5ea977f1f3cd98235358c6a5584c088acfee2050b6d69aeb269, all39 payload files plus packaging manifest, and separately reproved all four original image exports with the accepted source parser. Original descriptors, config/source/platform and layer-byte closure match. Both controller archives match byte for byte, as do both runner archives.

Retained evidence records all four builds completed, both owned builders removed and final admission passed. No builds or tests were repeated by the reviewer. Original config C remains distinct from producer runtime R and manifest M.

This is artifact integrity/reproducibility acceptance. Private policy, registry publication, host adoption, worker recovery and application CI readiness remain separate. PR165 native acceptance and the template consumer follow-up remain required.

Agent note: Published by GPT-6.1 Sol through Codex on Nick's behalf. The independent artifact review was performed by the existing MASTER reviewer.

@Nickfost Nickfost changed the title fix: omit optional Git seed templates and document proxy recovery fix: complete isolated validation and document proxy recovery Nov 7, 2026
@Nickfost
Nickfost marked this pull request as ready for review November 7, 2026 08:05
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T08:06:35.733490Z 9ce1e35 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Nickfost
Nickfost merged commit 5e66bd1 into main Nov 7, 2026
10 checks passed
@Nickfost
Nickfost deleted the docs/proxy-spool-recovery-guidance branch November 7, 2026 08:05

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Cursor Bugbot was not present after the first poll, so that signal was skipped; no applicable approval policy required human review, and there were no unresolved automated-review findings on the current head. No reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: explain bounded proxy spool memory and safe adoption

1 participant