Repository navigation
feat(config): add shared config blocks and load_config - #697
Open
atnair-amd wants to merge 3 commits into
Open
atnair-amd wants to merge 3 commits into
atnair-amd wants to merge 3 commits into
Conversation
atnair-amd
requested review from
anujmittal-amd,
cijohnson and
frepaul
as code owners
October 30, 2026 21:18
Security scan found no critical or high findings on lines changed by this pull request1 medium, low, or unrated finding(s) are not listed; the scan run has them. View the security scan run for complete reports. “New” means the finding is located in a changed file on an added or modified line; it is not a base-versus-head findings delta. |
Move Paths, ModelSpec, RuntimeSpec and ContainerSpec into config_blocks.py and add ConfigStr, RuntimeArgs and the threshold spec models, so suite schemas compose one set of blocks. config_loader re-exports the moved names. load_config loads a config against its cluster in one call: it resolves the cluster, substitutes the config, attaches thresholds, rejects leftover <changeme> placeholders, reports every problem without echoing input values, and merges the config's container block onto the cluster's. Keys starting with _ are now dropped at every model level, so a nested _comment that used to fail validation is ignored.
A nested cluster-only value in the merge was the same object as on the cluster dict. The merged container is now a copy, so editing it does not change the cluster. The loader tests no longer cover that merge. The placeholder test names the three ConfigStr fields it checks.
substitute_config, BaseVariantConfig and the block re-exports stay in cvs/lib/utils/config_loader.py, so other suites' imports do not change.
atnair-amd
force-pushed
the
atnair/config-blocks
branch
from
November 2, 2026 19:50
19c3393 to
a90b827
Compare
atnair-amd
requested review from
amd-droy,
ashutom and
solaiys
as code owners
November 2, 2026 19:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: AIMVT-574
A suite can pass its config file and cluster file to
load_configand get back a validated config, the resolved cluster, and the merged container. The shared blocks live inconfig_blocks.py. Other suites keep their own loaders.ConfigStrrejects<changeme>and<changeme-...>only whenload_configvalidates. A model validated with no context still accepts a template._is dropped at that model's own level. A key insideenvis kept.Testing:
test_config_loader(50 tests) and ruff on the follow-up commit.