Repository navigation
feat(vllm): build the vLLM config schema from the shared blocks - #698
Open
atnair-amd wants to merge 3 commits into
Open
atnair-amd wants to merge 3 commits into
atnair-amd wants to merge 3 commits into
Conversation
atnair-amd
requested review from
anujmittal-amd,
cijohnson and
frepaul
as code owners
October 30, 2026 21:18
Security scan found no critical or high findings on lines changed by this pull request2 medium, low, or unrated finding(s) are not listed; the scan run has them. View the security scan run for complete reports. “New” means the finding is located in a changed file on an added or modified line; it is not a base-versus-head findings delta. |
Move the vLLM schema into vllm_schema.py, composed from config_blocks, and load it through load_config. vllm_config_loader.py keeps load_variant and re-exports VariantConfig and serialize_cli_options. A config that still has a <changeme> or <changeme-...> value now fails at test collection, and the error names every such field, instead of failing later at image pull or docker run. Keys starting with _ are ignored at any level, including threshold metrics. runtime.args accepts the other Docker runtime keys and rejects env, so container.env stays the only env block. The suite's conftest takes the merged container from load_config and no longer keeps its own deep merge. The vLLM config tests move beside the schema. The packaged-catalog test is replaced by loading each shipped template with its placeholders filled.
The merge test loads a cluster env, volume list, and shm_size, and checks that editing the merged container does not change the cluster. The unfilled-template test names the placeholders that template's check reports.
The suite calls load_config with the schema directly, so vllm_config_loader.py and load_variant are removed.
atnair-amd
force-pushed
the
atnair/vllm-config-schema
branch
from
October 30, 2026 21:59
faae80e to
3e60b68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: AIMVT-575
vLLM loads through
load_config.VariantConfigis composed from the shared blocks, and the suite fixture uses the merged container from the loader. Depends on #697.<changeme>or<changeme-...>on aConfigStrfield, or in a CLI option value, fails at collection in oneConfigErrorthat names those fields. The check does not walk every string in the file.runtime.argsaccepts the other Docker keys and rejectsenv.HF_TOKENandHUGGING_FACE_HUB_TOKENin the suite file'scontainer.envstill fail the load. A token set only in the cluster file is kept, and logs redact it through the existingenv_libpath._is ignored.notesis still rejected.The how-to, the reference, and the 0.3.0 changelog bullet say every leftover placeholder is named. The check is the
ConfigStrand option-value fields.Testing:
test_vllm_config_loader(4 tests) and ruff on the follow-up commit.