Skip to content

murdock-worker/Dockerfile: update git-cache-rs to the latest version#265

Closed
crasbe wants to merge 2 commits into
RIOT-OS:masterfrom
crasbe:pr/update_git-cache-rs
Closed

murdock-worker/Dockerfile: update git-cache-rs to the latest version#265
crasbe wants to merge 2 commits into
RIOT-OS:masterfrom
crasbe:pr/update_git-cache-rs

Conversation

@crasbe
Copy link
Copy Markdown
Contributor

@crasbe crasbe commented Apr 20, 2026

The git-cache-rs version specified in the Dockerfile is very old and does not seem to work anymore?
On my local ThinkPad that acts as a CI worker currently, only git-cache files were present but no git-cache-rs folders.

riotbuild@b84655cf2cf7:/cache/.gitcache$ ls -l
total 520
drwxr-xr-x 7 riotbuild root 4096 Oct 14  2025 10077753813265320433.git
-rw-r--r-- 1 riotbuild root    0 Apr 20 16:38 10077753813265320433.lock
drwxr-xr-x 7 riotbuild root 4096 Oct 14  2025 10223567230215662083.git
-rw-r--r-- 1 riotbuild root    0 Apr 20 14:55 10223567230215662083.lock
drwxr-xr-x 7 riotbuild root 4096 Oct 23 23:55 1022674748962676621.git
-rw-r--r-- 1 riotbuild root    0 Oct 23 23:55 1022674748962676621.lock
drwxr-xr-x 7 riotbuild root 4096 Oct 14  2025 10275685405471410120.git
-rw-r--r-- 1 riotbuild root    0 Apr 20 17:22 10275685405471410120.lock
drwxr-xr-x 7 riotbuild root 4096 Oct 14  2025 10395226093010920096.git
-rw-r--r-- 1 riotbuild root    0 Apr 20 17:23 10395226093010920096.lock
drwxr-xr-x 7 riotbuild root 4096 Oct 14  2025 10412693831896225484.git
-rw-r--r-- 1 riotbuild root    0 Apr 20 17:06 10412693831896225484.lock
drwxr-xr-x 7 riotbuild root 4096 Oct 14  2025 10556324815249665068.git
-rw-r--r-- 1 riotbuild root    0 Apr 20 16:33 10556324815249665068.lock
drwxr-xr-x 7 riotbuild root 4096 Oct 14  2025 10620790921438452123.git
...

This PR just bumps the version of git-cache-rs to the latest version.

Verified to work on my local machine:

riotbuild@d852a7ef1af4:/cache/.gitcache$ ls -l
total 528
drwxr-xr-x  7 riotbuild root 4096 Oct 14  2025 10077753813265320433.git
-rw-r--r--  1 riotbuild root    0 Apr 20 16:38 10077753813265320433.lock
...
drwxr-xr-x  7 riotbuild root 4096 Oct 14  2025 9609903824853689138.git
-rw-r--r--  1 riotbuild root    0 Apr 20 16:34 9609903824853689138.lock
drwxr-xr-x  3 riotbuild root 4096 Apr 20 17:55 git.riot-os.org
drwxr-xr-x 14 riotbuild root 4096 Apr 20 18:04 github.com

@crasbe crasbe added the dependencies Pull requests that update a dependency file label Apr 20, 2026
@crasbe
Copy link
Copy Markdown
Contributor Author

crasbe commented Apr 20, 2026

Discovered in RIOT-OS/RIOT#22197 .

@crasbe crasbe force-pushed the pr/update_git-cache-rs branch from 171b804 to 955b071 Compare April 20, 2026 22:17
@crasbe
Copy link
Copy Markdown
Contributor Author

crasbe commented Apr 21, 2026

In the latest fixups, I utilized the feature from RIOT-OS/RIOT#21815 to avoid the static test failing because of the Docker container ID mismatch.

@crasbe
Copy link
Copy Markdown
Contributor Author

crasbe commented Apr 23, 2026

In the latest fixups, I utilized the feature from RIOT-OS/RIOT#21815 to avoid the static test failing because of the Docker container ID mismatch.

This is now outsourced into another PR.

@crasbe crasbe added State: waiting for PR This PR is waiting for another PR to be merged. State: waiting for release This PR is ready, but waiting for the upcoming release to happen to avoid CI chaos. State: needs rebase The PR has to be rebased to avoid merge conflicts or include features from another PR. labels Apr 23, 2026
@crasbe crasbe force-pushed the pr/update_git-cache-rs branch from 97d5d7e to efa5c76 Compare May 7, 2026 11:26
@crasbe crasbe removed State: waiting for release This PR is ready, but waiting for the upcoming release to happen to avoid CI chaos. State: waiting for PR This PR is waiting for another PR to be merged. State: needs rebase The PR has to be rebased to avoid merge conflicts or include features from another PR. labels May 7, 2026
Also add a line to the Dockerfile to remove the old style cache
content to save some valuable harddrive space.
@crasbe crasbe force-pushed the pr/update_git-cache-rs branch from efa5c76 to 7ef3d87 Compare May 7, 2026 11:27
Copy link
Copy Markdown
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me, not tested though due to lacking suitable test environment. Therefore trusting your testing :)

@crasbe crasbe added the State: waiting for PR This PR is waiting for another PR to be merged. label May 11, 2026
@crasbe crasbe force-pushed the pr/update_git-cache-rs branch from d9a1dce to de0cea8 Compare May 11, 2026 12:40
@crasbe
Copy link
Copy Markdown
Contributor Author

crasbe commented May 11, 2026

Integrated into #266.

@crasbe crasbe closed this May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file State: waiting for PR This PR is waiting for another PR to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants