Skip to content

github/workflows: Bump Version and don't pin docker image for static test#267

Merged
maribu merged 2 commits into
RIOT-OS:masterfrom
crasbe:pr/bump_version
May 7, 2026
Merged

github/workflows: Bump Version and don't pin docker image for static test#267
maribu merged 2 commits into
RIOT-OS:masterfrom
crasbe:pr/bump_version

Conversation

@crasbe
Copy link
Copy Markdown
Contributor

@crasbe crasbe commented Apr 23, 2026

Extracted from #265.

The changes utilize the feature from RIOT-OS/RIOT#21815 to avoid the static test failing because of the Docker container ID mismatch.

@crasbe crasbe requested a review from AnnsAnns April 23, 2026 09:53
@crasbe crasbe added enhancement State: waiting for release This PR is ready, but waiting for the upcoming release to happen to avoid CI chaos. labels Apr 23, 2026
@crasbe crasbe removed the State: waiting for release This PR is ready, but waiting for the upcoming release to happen to avoid CI chaos. label May 6, 2026
@maribu maribu changed the title github/workflows: Bump Version and don't pin docker image for build test github/workflows: Bump Version and don't pin docker image for static test May 6, 2026
Copy link
Copy Markdown
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Please update the commit message that the pinning is lifted for the static test, not for the build test.

@crasbe
Copy link
Copy Markdown
Contributor Author

crasbe commented May 6, 2026

lgtm. Please update the commit message that the pinning is lifted for the static test, not for the build test.

Technically both is true. How about ... don't pin docker image for static test in build test?

@crasbe crasbe force-pushed the pr/bump_version branch from 2f27e45 to 046f882 Compare May 6, 2026 18:10
@AnnsAnns
Copy link
Copy Markdown
Member

AnnsAnns commented May 7, 2026

Can this be merged?

@maribu maribu added this pull request to the merge queue May 7, 2026
@AnnsAnns
Copy link
Copy Markdown
Member

AnnsAnns commented May 7, 2026

Guess so 😆

Merged via the queue into RIOT-OS:master with commit 9882a0b May 7, 2026
1 check passed
@maribu
Copy link
Copy Markdown
Member

maribu commented May 7, 2026

Can this be merged?

Yes, merging worked just fine 😜

@crasbe crasbe deleted the pr/bump_version branch May 7, 2026 10:44
@crasbe
Copy link
Copy Markdown
Contributor Author

crasbe commented May 7, 2026

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants