Skip to content

ci(console): register S2 desk N1 release source c0ac5848 (#1166) - #1167

Merged
Pigbibi merged 1 commit into
mainfrom
ci/register-s2-desk-release-source
Nov 14, 2026
Merged

Pigbibi merged 1 commit into
mainfrom
ci/register-s2-desk-release-source

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

AI assistance

Claude Code, model Opus 5.5 (native box job, single writer).

What changed

Registers the merged #1166 commit c0ac5848b8af983d4f857e465c6ff64009b0957f (the S2 Desk N1 live flip) as a dedicated, fail-closed reviewed-main release source in deploy-strategy-switch-console.yml. This follows the same pattern as the S1 source 1618b248 (#1134). Every prior source definition is unchanged.

  • Selector (Select reviewed historical main source): pins the exact source and these blobs:

    The run must use the main ref, frontend release mode, no secret or profile sync, and receiver checks retained. CONTROL must equal the run SHA and differ from SOURCE, and SOURCE must be an ancestor of CONTROL.

  • Overlay: the selected head must equal its tree, and the rebuilt map must equal the pinned blob, with no staged, unstaged or untracked delta. It is bound to this source input.

  • Publisher: it uses the current reviewed-main path:

    • the active version is the sole configuration donor;
    • the upload is version-pinned;
    • a separate concurrency witness is kept;
    • module, migration and configuration checks run;
    • activation is 100%.
  • Tests (tests/console_deploy_safety_validation.mjs):

    • real-Git identity: five pins, ancestry and a new map generation. The map has 45 assets, keeps the S1 delivery guard and carries the N1 switch-strategies projection. The Worker keeps the S1 producer field and serves the N1 routes;
    • accepted-source call order;
    • mode, ref and unknown-source rejection before any Git call;
    • wrong parent, tree, map, Worker or reader test, object, ancestry or CONTROL (including the S1 entry Worker and map);
    • no cross-acceptance with 1618b248;
    • overlay tampering;
    • publisher witness and drift cases.

What ships with this source: since the published S1 source 1618b248, main gained 25 commits. They are the two S2 PRs (#1150, #1166), the runtime_support module-extraction refactor wave (#1137–#1165), two digest fixes (#1135, #1157) and governance pins. There is no dependency, lockfile or wrangler change; only the test:operations scripts changed. Bundling the source Worker graph locally gives one 2.9 MB module (the workflow limit is 10 MiB).

How verified

  • node tests/console_deploy_safety_validation.mjs: PASS. Source cases went from 269 to 304 and overlay cases from 54 to 66, with 257 isolated release cases.
  • Fail-before:
    • Against the workflow on main: AssertionError: invalid_frontend_release_mode.
    • With only the Worker pin removed: AssertionError: rev-parse c0ac5848…:web/strategy-switch-console/worker.js.
    • With the source removed from the overlay: S2 Desk N1 overlay must validate exact pins: {}.
    • With the source removed from the publisher allowlist: frontend_release_stopped … pre_upload_active.
  • Every Node test that reads this workflow passes: binance_receiver_deploy_acceptance_validation, console_946_backend_workflow.test, console_catalog_release_validation, console_deploy_safety_validation, console_version_comparator_validation, website_release_combination_validation.
  • Python workflow tests (test_console_config_compare, test_runtime_settings, test_ux1_deploy_workflow): 211 passed, 1 skipped.
  • git diff --check: clean.

Why

#1166 produced a new immutable frontend bundle (map 281002ea) and Worker blob. The deploy workflow only publishes explicitly registered sources, so this source must be registered before the already-authorized S2 console publish.

Risk

  • Tier: release workflow registration (CI/deploy path). Only an exact, pinned main-history source is added, and every other source path is unchanged.
  • No Secret or profile sync, no new permission, no migration (the publisher still rejects candidate migrations) and no change to write routes.
  • Merging this does not deploy anything. A deploy still needs a separate manual workflow_dispatch with this exact source_sha.

Register the merged #1166 Desk N1 live-flip commit as a dedicated,
fail-closed reviewed-main release source in the console deploy workflow.
Prior source definitions, including the S1 1618b24 pins, are unchanged.

- Selector: exact source, sole parent af897f8, tree a7b327c, v2 map
  blob 281002e and Worker blob bbe906c; the source tree must also carry
  the reviewed #1126 reader test f590e43, so nothing is composed. main
  ref, CONTROL equal to the run SHA and distinct from SOURCE, SOURCE an
  ancestor of CONTROL; receiver checks retained; no secret or profile
  sync.
- Overlay: the selected head must match its tree and pinned map after
  rebuild, bound to this source input, with no staged, unstaged or
  untracked delta.
- Publisher: current reviewed-main path (active version as sole
  configuration donor, version-pinned upload, separate concurrency
  witness, module/migration/configuration checks, 100% activation).
- Tests: real-Git identity, map generation and N1 Worker routes;
  accepted source, mode, ref and unknown-source rejection; wrong
  parent/tree/map/Worker/reader test/ancestry/CONTROL; no
  cross-acceptance with 1618b24; overlay tampering and publisher
  witness/drift cases.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Pigbibi
Pigbibi marked this pull request as ready for review November 14, 2026 04:05
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T04:08:23.089797Z 050cad3 Draft marked ready
🔒 Security Review ✅ Completed 2026-11-14T04:10:24.619115Z 050cad3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Pigbibi Pigbibi added the agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation label Nov 14, 2026
@Pigbibi
Pigbibi merged commit 9ba46c2 into main Nov 14, 2026
20 of 22 checks passed
@Pigbibi
Pigbibi deleted the ci/register-s2-desk-release-source branch November 14, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants