Repository navigation
ci(console): register S2 desk N1 release source c0ac5848 (#1166) - #1167
Merged
Merged
Conversation
Register the merged #1166 Desk N1 live-flip commit as a dedicated, fail-closed reviewed-main release source in the console deploy workflow. Prior source definitions, including the S1 1618b24 pins, are unchanged. - Selector: exact source, sole parent af897f8, tree a7b327c, v2 map blob 281002e and Worker blob bbe906c; the source tree must also carry the reviewed #1126 reader test f590e43, so nothing is composed. main ref, CONTROL equal to the run SHA and distinct from SOURCE, SOURCE an ancestor of CONTROL; receiver checks retained; no secret or profile sync. - Overlay: the selected head must match its tree and pinned map after rebuild, bound to this source input, with no staged, unstaged or untracked delta. - Publisher: current reviewed-main path (active version as sole configuration donor, version-pinned upload, separate concurrency witness, module/migration/configuration checks, 100% activation). - Tests: real-Git identity, map generation and N1 Worker routes; accepted source, mode, ref and unknown-source rejection; wrong parent/tree/map/Worker/reader test/ancestry/CONTROL; no cross-acceptance with 1618b24; overlay tampering and publisher witness/drift cases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pigbibi
marked this pull request as ready for review
November 14, 2026 04:05
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
Claude Code, model Opus 5.5 (native box job, single writer).
What changed
Registers the merged #1166 commit
c0ac5848b8af983d4f857e465c6ff64009b0957f(the S2 Desk N1 live flip) as a dedicated, fail-closed reviewed-main release source indeploy-strategy-switch-console.yml. This follows the same pattern as the S1 source1618b248(#1134). Every prior source definition is unchanged.Selector (
Select reviewed historical main source): pins the exact source and these blobs:af897f8b;a7b327c0;281002ea;bbe906c5;f590e43dfrom its own tree. Nothing is composed onto it.The run must use the main ref, frontend release mode, no secret or profile sync, and receiver checks retained. CONTROL must equal the run SHA and differ from SOURCE, and SOURCE must be an ancestor of CONTROL.
Overlay: the selected head must equal its tree, and the rebuilt map must equal the pinned blob, with no staged, unstaged or untracked delta. It is bound to this source input.
Publisher: it uses the current reviewed-main path:
Tests (
tests/console_deploy_safety_validation.mjs):1618b248;What ships with this source: since the published S1 source
1618b248, main gained 25 commits. They are the two S2 PRs (#1150, #1166), theruntime_supportmodule-extraction refactor wave (#1137–#1165), two digest fixes (#1135, #1157) and governance pins. There is no dependency, lockfile or wrangler change; only thetest:operationsscripts changed. Bundling the source Worker graph locally gives one 2.9 MB module (the workflow limit is 10 MiB).How verified
node tests/console_deploy_safety_validation.mjs: PASS. Source cases went from 269 to 304 and overlay cases from 54 to 66, with 257 isolated release cases.AssertionError: invalid_frontend_release_mode.AssertionError: rev-parse c0ac5848…:web/strategy-switch-console/worker.js.S2 Desk N1 overlay must validate exact pins: {}.frontend_release_stopped … pre_upload_active.binance_receiver_deploy_acceptance_validation,console_946_backend_workflow.test,console_catalog_release_validation,console_deploy_safety_validation,console_version_comparator_validation,website_release_combination_validation.test_console_config_compare,test_runtime_settings,test_ux1_deploy_workflow): 211 passed, 1 skipped.git diff --check: clean.Why
#1166 produced a new immutable frontend bundle (map
281002ea) and Worker blob. The deploy workflow only publishes explicitly registered sources, so this source must be registered before the already-authorized S2 console publish.Risk
workflow_dispatchwith this exactsource_sha.