Repository navigation
ci(console): register S2 desk gap-fill release source 2fa23318 - #1169
Merged
Merged
Conversation
Register the merged #1168 Desk gap-fill commit as a dedicated, fail-closed reviewed-main release source in the console deploy workflow. Prior source definitions, including the S2 c0ac584 pins, are unchanged. - Selector: exact source, sole parent 9ba46c2, tree 55da6c6, v2 map blob 05155b3 and Worker blob bbe906c; the source tree must also carry the reviewed #1126 reader test f590e43, so nothing is composed. main ref, CONTROL equal to the run SHA and distinct from SOURCE, SOURCE an ancestor of CONTROL; receiver checks retained; no secret or profile sync. - Overlay: the selected head must match its tree and pinned map after rebuild, bound to this source input, with no delta. - Publisher: current reviewed-main path with the separate concurrency witness. - Tests: real-Git identity, map generation and the stored sparkline read; accepted source and mode/ref/unknown-source rejection; wrong parent/tree/map/Worker/reader test/ancestry/CONTROL; no cross-acceptance with c0ac584; overlay tampering and publisher witness/drift cases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pigbibi
marked this pull request as ready for review
November 14, 2026 08:41
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
Claude Code, model Opus 5.5 (native box job, single writer).
What changed
Registers the merged #1168 Desk gap-fill commit
2fa23318as a dedicated, fail-closed reviewed-main release source indeploy-strategy-switch-console.yml. The block is structurally identical to the S2c0ac5848block (#1167); only the pins differ. Every prior source definition is unchanged.Selector: exact source, with these pins:
9ba46c2d, tree55da6c63;05155b33and Worker blobbbe906c5;f590e43d, which must already be in the source tree, so nothing is composed.The run must also use the main ref and frontend mode, with no secret or profile sync and receiver checks retained. CONTROL must equal the run SHA and differ from SOURCE, and SOURCE must be an ancestor of CONTROL.
Overlay: the selected head must match its tree, and the rebuilt map must match the pinned map blob. The run must be bound to this source input, with no staged, unstaged or untracked delta.
Publisher: added to the current reviewed-main allowlist, which uses the separate concurrency witness.
Tests (
tests/console_deploy_safety_validation.mjs):How verified
Node 22.23.4, isolated checkout.
AssertionError: invalid_frontend_release_mode. It passes with this change.console_deploy_safety,console_catalog_release,console_946_backend_workflow,binance_receiver_deploy_acceptance,console_version_comparator,website_release_combination).publication-check/2.0-advisory(build53bfc794) on the two changed files: 147 advisory matches, all on pre-existing lines. A separate scan of only the 143 added lines finds 0 matches, and none is a credential.Why
The console deploy workflow only publishes explicitly registered sources. #1168 produced a new immutable frontend bundle (
v2_asset_map.jsblob05155b33), so registration is required before the already-authorized S2 console publish.Risk