Skip to content

refactor: extract strategy-switch worker into application modules - #1137

Merged
Pigbibi merged 9 commits into
mainfrom
refactor/untangle-p0-p2
Nov 13, 2026
Merged

Pigbibi merged 9 commits into
mainfrom
refactor/untangle-p0-p2

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

AI assistance

Cursor Auto (Composer) with local agent session. Owner authorized commit, push, and merge for this untangle refactor batch.

What changed

  • Structure-only refactor for high cohesion / low coupling (module splits, re-exports, compatibility shims).
  • No intentional change to HTTP/CLI contracts, order semantics, or secrets handling.

How verified

  • Local focused checks as listed in the prior PR summary (imports/AST/unit where applicable).
  • CI re-run on updated head after commitlint body fix and export/test follow-ups.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T20:09:02.898816Z e28d923 New commits
🔒 Security Review ✅ Completed 2026-11-13T20:12:01.746468Z e28d923 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Pigbibi
Pigbibi enabled auto-merge (squash) November 13, 2026 18:49
Pigbibi and others added 2 commits November 14, 2026 02:53
Move UX1, auth, RuntimeInstances, and shared helpers into application/.

Co-authored-by: Cursor <cursoragent@cursor.com>
Structural tests now find functions moved out of worker.js.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Pigbibi
Pigbibi force-pushed the refactor/untangle-p0-p2 branch from 5ced904 to 9a853c3 Compare November 13, 2026 18:54
@Pigbibi Pigbibi added the agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation label Nov 13, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9a853c3636

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Keep RuntimeInstances import-bound for Miniflare subclasses and convert
history-trigger aborts into HttpError so management APIs do not report 503.

Co-authored-by: Cursor <cursoragent@cursor.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea35667962

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/strategy-switch-console/worker.js Resolved
Export bootstrap assets, import DO stale/error symbols, and point
source-shape validations at runtime_support after the worker split.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Pigbibi Pigbibi added risk:low Documentation, tests or ordinary checks; automated path classification remains authoritative. agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation and removed agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation labels Nov 13, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f2827d6666

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Account-facts, benchmark and stop/audit constants were referenced after
the RuntimeInstances split without imports, collapsing writes to 409.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Pigbibi Pigbibi added agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation and removed agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation labels Nov 13, 2026
Historical put paths referenced normalizeAccountFactsHistoricalPayload
without an import, which collapsed contract writes to 409.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Pigbibi Pigbibi added agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation and removed agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation labels Nov 13, 2026
Pigbibi and others added 3 commits November 14, 2026 03:51
Worker facade no longer contains account_facts_put literals after the
RuntimeInstances split; inspect support and DO sources instead.

Co-authored-by: Cursor <cursoragent@cursor.com>
Period-return conflict reads spread this constant; without the import
the path threw and left the default external_cashflow_required reason.

Co-authored-by: Cursor <cursoragent@cursor.com>
Import publicMarketBenchmarkReadModel and OAUTH_STATE_COOKIE, re-share
UX1 body helpers with runtime_support, and scan profileState in support.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Pigbibi Pigbibi added agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation risk:low Documentation, tests or ordinary checks; automated path classification remains authoritative. and removed risk:low Documentation, tests or ordinary checks; automated path classification remains authoritative. agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation labels Nov 13, 2026
@Pigbibi
Pigbibi merged commit d129b4c into main Nov 13, 2026
35 of 40 checks passed
@Pigbibi
Pigbibi deleted the refactor/untangle-p0-p2 branch November 13, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation risk:low Documentation, tests or ordinary checks; automated path classification remains authoritative.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant