Repository navigation
fix: Pin reviewed main frontend release 084ba428 - #1089
Merged
Merged
Conversation
Accept the merged decision-inbox main as an exact console release source and keep the previous reviewed main as a historical pin. Receiver checks stay enabled, and secret, profile, and other release modes stay off. Co-authored-by: Pigbibi <Pigbibi@users.noreply.github.com>
Pigbibi
marked this pull request as ready for review
November 8, 2026 13:59
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
Cursor Grok 4.7.
What changed
The manual Strategy Switch Console deploy entry now accepts the already-merged reviewed main
084ba4281cfff3304cf226ce511a2fc0a6b67b08as an exact frontend release source. The previous reviewed mainc1b737d6e721eb9fe71a12c613fbb49d3fa51563stays an exact historical pin, the same way other historical release SHAs remain individually allowlisted. No arbitrary SHA is accepted.The new selector uses the same gates as the existing reviewed-main block:
refs/heads/main,release_frontend_assets=true,sync_secrets=false,sync_strategy_profiles=false,skip_binance_receiver_checks=false, ancestry against the workflow control revision, the pinned tree, the pinned asset map, and a detached checkout. The overlay step skips the legacy frontend overlay only for these two exact SHAs, each with its own tree and asset-map check. Publication keeps version-pinned binding inheritance for both reviewed-main SHAs.Verified from
origin/mainbefore editing:084ba4281cfff3304cf226ce511a2fc0a6b67b08395ddd561a16d38ae0d145e5a7e9bb7b60c44ae623f94567c2e8b631e8ef035bfea497acef795123web/strategy-switch-console/v2_asset_map.jsblob5287f259185ed44f3784aa6374cb00412b3c6238How verified
node tests/console_deploy_safety_validation.mjs— exit 0. Summary:console_deploy_safety_validation: PASS (manual-only; 16 original write gates; exclusive preflight/deploy/restore; 2 exact Binance gates; 52 offline reader cases; 178 source cases; 29 restore cases; 19 overlay cases; 2 config cases; 257 isolated release cases; 24 schema readback cases).python3 scripts/check_style.py --phase 2— exit 0, 0 blocking. One pre-existing README advisory remains.No Deploy or Publish workflow was dispatched. No merge.
Why
Deploy Strategy Switch Console cannot release the squash-merged #1086 frontend because
084ba4281cfff3304cf226ce511a2fc0a6b67b08is absent from the reviewed-main allowlist. This is the same class of blocker #1082 fixed forc1b737d6e721eb9fe71a12c613fbb49d3fa51563.Risk
High: protected manual release workflow. This draft only extends the exact-SHA allowlist. It does not deploy, does not change workflow permissions, and does not enable secret sync, strategy-profile sync, Meridian activation, external flow, IBKR resume, backend-only release, rollback, or read-only modes.
Eventual release dispatch, not performed here, remains:
release_frontend_assets=truesource_sha=084ba4281cfff3304cf226ce511a2fc0a6b67b08sync_secrets=falsesync_strategy_profiles=falseskip_binance_receiver_checks=falseexternal_flow_enable=falseibkr_candidate_resume=offrender_and_compare_only=falseprivate_release_check=offread_only_preflight=falsediagnose_restore_target=falsecheck_explicit_version_inherit=falsebackend_only_release=falserollback_to_pre_release=falseRO-M07 HOLD stays in place: this pin does not enable
sync_strategy_profilesor Meridian activation. Runtime adoption is not proven by this change.