Repository navigation
ci: Pin reviewed main frontend release dd63b3c8 - #1098
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e85afa069e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI assistance
AI: DeepSeek coding agent (WorkBuddy session). The owner asked for the reviewed main console to be released; this PR is the release pin that makes that possible, following the same shape as #1089.
What changed
One file,
.github/workflows/deploy-strategy-switch-console.yml(+26/−4). No application code, no asset, no Worker source.Select reviewed historical main sourcedd63b3c8b73b588ce411316d904efd26f2c4f382; the084ba428block keeps its exact checks and is relabelled historicalOverlay fixed reviewed frontend assetsreviewed_mainbecomesdd63b3c8…;084ba428…andc1b737d6…join the historical branch with their existing tree and asset-map checkscurrentReviewedMainbecomesdd63b3c8…;reviewedMainaccepts the new source and both historical onesThe new block carries the same gates as the release it replaces:
refs/heads/mainonly,frontend_mode=true,SYNC_SECRETS=false,SYNC_STRATEGY_PROFILES=false,SKIP_BINANCE_RECEIVER_CHECKS=false, ancestry of the workflow ref, then exact tree andv2_asset_map.jsblob before a detached checkout.Scope between the previous release source and this one: 13 commits, 85 files, +5529/−351, of which the console frontend is 28 files, +1649/−66 (
desk/pages/OverviewPage.tsx+254,desk/styles/desk.css+140,worker.js+7,v2_asset_map.jsrebuilt).How verified
actionlinton the workflow → clean.yaml.safe_load→ 5 jobs, unchanged names.bash -non both edited scripts → clean.run:script and ran it in a scratch clone withRELEASE_SOURCE_SHA=dd63b3c8…,RELEASE_FRONTEND_ASSETS=true,SYNC_SECRETS=false,SYNC_STRATEGY_PROFILES=false,SKIP_BINANCE_RECEIVER_CHECKS=false,IBKR_CANDIDATE_RESUME=off,GITHUB_REF=refs/heads/main,GITHUB_SHAset to the control commit: exit 0, and the worktree ended detached atdd63b3c8….2f7b0b22) → exit 2; the approved source withSKIP_BINANCE_RECEIVER_CHECKS=true→ exit 2; withSYNC_SECRETS=true→ exit 2. The pin widens exactly one source and no flag combination.git rev-parsefrom the commit itself, not copied from a run log.Why
maincarries the reviewed console frontend (dd63b3c8, #1097 desk pages: alerts, logs, overview), but the workflow only accepts the sources listed in it, and the live bundle still servesindex-B3FhKPj3.jswhilemainbuildsindex-BKZGSOEi.js. Without this pin the reviewed main cannot be released:unapproved_console_release_source.Risk
Medium, and deliberately so: this is a release-authorization file, and it is the only change in the PR. Merging it does not deploy anything — a dispatch is still required, and the dispatch runs the full preflight, receiver checks and post-release readback. If any hash or flag disagrees, the job exits 2 before a checkout, exactly as before. Reviewer checks stay enabled; secrets, profiles and other release modes stay off.
This PR is R2 (deploy path). The clearing label is for the reviewer receipt, not a substitute for the owner's own approval of the release.
AI: DeepSeek coding agent.