Skip to content

ci: Pin reviewed main frontend release dd63b3c8 - #1098

Merged
Pigbibi merged 2 commits into
mainfrom
ci/pin-console-dd63b3c8
Nov 9, 2026
Merged

Pigbibi merged 2 commits into
mainfrom
ci/pin-console-dd63b3c8

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

AI assistance

AI: DeepSeek coding agent (WorkBuddy session). The owner asked for the reviewed main console to be released; this PR is the release pin that makes that possible, following the same shape as #1089.

What changed

One file, .github/workflows/deploy-strategy-switch-console.yml (+26/−4). No application code, no asset, no Worker source.

where change
Select reviewed historical main source new block accepting dd63b3c8b73b588ce411316d904efd26f2c4f382; the 084ba428 block keeps its exact checks and is relabelled historical
Overlay fixed reviewed frontend assets reviewed_main becomes dd63b3c8…; 084ba428… and c1b737d6… join the historical branch with their existing tree and asset-map checks
release classification currentReviewedMain becomes dd63b3c8…; reviewedMain accepts the new source and both historical ones

The new block carries the same gates as the release it replaces: refs/heads/main only, frontend_mode=true, SYNC_SECRETS=false, SYNC_STRATEGY_PROFILES=false, SKIP_BINANCE_RECEIVER_CHECKS=false, ancestry of the workflow ref, then exact tree and v2_asset_map.js blob before a detached checkout.

dd63b3c8b73b588ce411316d904efd26f2c4f382
  parent   2f7b0b22b376b36d3767f08a2715acc1bee640e5
  tree     c08d5542b032abaa008e882dd97ed2c38b3ad236
  asset map a7237657bb6e48c57e947875f629d28bafb5ea27

Scope between the previous release source and this one: 13 commits, 85 files, +5529/−351, of which the console frontend is 28 files, +1649/−66 (desk/pages/OverviewPage.tsx +254, desk/styles/desk.css +140, worker.js +7, v2_asset_map.js rebuilt).

How verified

  • actionlint on the workflow → clean. yaml.safe_load → 5 jobs, unchanged names.
  • bash -n on both edited scripts → clean.
  • The selector was executed, not just read. Extracted the run: script and ran it in a scratch clone with RELEASE_SOURCE_SHA=dd63b3c8…, RELEASE_FRONTEND_ASSETS=true, SYNC_SECRETS=false, SYNC_STRATEGY_PROFILES=false, SKIP_BINANCE_RECEIVER_CHECKS=false, IBKR_CANDIDATE_RESUME=off, GITHUB_REF=refs/heads/main, GITHUB_SHA set to the control commit: exit 0, and the worktree ended detached at dd63b3c8….
  • Negative cases on the same script: an unapproved source (2f7b0b22) → exit 2; the approved source with SKIP_BINANCE_RECEIVER_CHECKS=true → exit 2; with SYNC_SECRETS=true → exit 2. The pin widens exactly one source and no flag combination.
  • The three hashes in the table were read with git rev-parse from the commit itself, not copied from a run log.

Why

main carries the reviewed console frontend (dd63b3c8, #1097 desk pages: alerts, logs, overview), but the workflow only accepts the sources listed in it, and the live bundle still serves index-B3FhKPj3.js while main builds index-BKZGSOEi.js. Without this pin the reviewed main cannot be released: unapproved_console_release_source.

Risk

Medium, and deliberately so: this is a release-authorization file, and it is the only change in the PR. Merging it does not deploy anything — a dispatch is still required, and the dispatch runs the full preflight, receiver checks and post-release readback. If any hash or flag disagrees, the job exits 2 before a checkout, exactly as before. Reviewer checks stay enabled; secrets, profiles and other release modes stay off.

This PR is R2 (deploy path). The clearing label is for the reviewer receipt, not a substitute for the owner's own approval of the release.

AI: DeepSeek coding agent.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T13:59:21.845161Z 9d2ce24 New commits
🔒 Security Review ✅ Completed 2026-11-09T14:03:33.650813Z 9d2ce24 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e85afa069e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi Pigbibi added the agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation label Nov 9, 2026
@Pigbibi
Pigbibi merged commit c2cf60b into main Nov 9, 2026
22 of 23 checks passed
@Pigbibi
Pigbibi deleted the ci/pin-console-dd63b3c8 branch November 9, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant