Skip to content

fix: Accept the reviewed main frontend release source - #1082

Merged
Pigbibi merged 2 commits into
mainfrom
fix/reviewed-main-frontend-release
Nov 7, 2026
Merged

Pigbibi merged 2 commits into
mainfrom
fix/reviewed-main-frontend-release

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

AI assistance

Codex (host-selected GPT-6 family; exact version unavailable).

What changed

Allow the already-reviewed merged main frontend release in the manual console entry. Pin its exact source, tree and asset map; require frontend-only inputs, keep receiver checks enabled, and reject Secret/profile sync. After the build, verify the same map and clean output instead of applying the legacy frontend overlay. Update the existing release evidence documentation and offline safety tests.

How verified

  • Reproduced invalid_frontend_release_mode before the selector repair, then separately reproduced overlay rejection before its repair; both regressions now pass.
  • Source guards reject invalid flags and control/object/ancestry/tree/blob/checkout mismatches; overlay guards reject tampering and dirty output.
  • Full Python suite: 1140 tests, 10 skipped, PASS in isolated same-candidate clone. The shared workspace has three sibling-repository discovery failures in one compatibility test; no test or production logic was relaxed.
  • Full Web CI command block: PASS with CI Node 22, including build, asset sync, operations and validation scripts. Default Node 24 is incompatible with an existing experimental flag. All three historical bundle-fixture checks PASS after fetching the missing fixed historical commit; offline Worker runtime and non-target-byte preservation verified.
  • actionlint, documentation style, projection checks, runtime-settings validation and diff whitespace checks PASS. Existing README style advisory only.

Why

The prior authorized FE-only dispatch stopped before deployment because this merged release was absent from the legacy source allowlist. The downstream overlay also expected legacy assets. This change adds one exact reviewed main release without admitting arbitrary SHAs.

Risk

High: protected manual release workflow. Existing job selection, Secret/profile synchronization, external-flow/resume, rollback, permissions, Environment and runtime configuration preservation gates remain intact. Draft only. No deployment dispatch, Secret sync, Environment approval, trading or risk-switch change in this job. Remote CI and exact-head review are pending; runtime adoption remains NOT_PROVEN.

Central publication checker

publication-check/2.0-advisory, build 83d9d1130377: 3961 matching lines / 3964 findings across the complete tracked tree (advisory). First 20 masked matches:

  • .github/CODEOWNERS:4: /.github/CODEOWNERS @<PROJECT_ID>
  • .github/CODEOWNERS:5: /.github/workflows/ @<PROJECT_ID>
  • .github/CODEOWNERS:6: /actions/publish-runtime-execution-evidence/ @<PROJECT_ID>
  • .github/CODEOWNERS:7: /python/scripts/check_credential_maintenance_read.py @<PROJECT_ID>
  • .github/CODEOWNERS:8: /python/scripts/credential_maintenance_notify.py @<PROJECT_ID>
  • .github/CODEOWNERS:9: /python/scripts/deployment_bundle_contract.py @<PROJECT_ID>
  • .github/CODEOWNERS:10: /python/scripts/deterministic_risk_gate.py @<PROJECT_ID>
  • .github/CODEOWNERS:11: /python/scripts/execution_evidence_projection.py @<PROJECT_ID>
  • .github/CODEOWNERS:12: /python/scripts/forward_observation_risk_control.py @<PROJECT_ID>
  • .github/CODEOWNERS:13: /python/scripts/long_horizon_risk_composer.py @<PROJECT_ID>
  • .github/CODEOWNERS:14: /python/scripts/long_horizon_risk_composer_v2.py @<PROJECT_ID>
  • .github/CODEOWNERS:15: /python/scripts/long_horizon_risk_observation_ingress.py @<PROJECT_ID>
  • .github/CODEOWNERS:16: /python/scripts/long_horizon_risk_observation_ingress_v2.py @<PROJECT_ID>
  • .github/CODEOWNERS:17: /python/scripts/paper_risk_admission_receipt.py @<PROJECT_ID>
  • .github/CODEOWNERS:18: /schemas/qsl-deployment-bundle.v1.schema.json @<PROJECT_ID>
  • .github/CODEOWNERS:19: /schemas/qsl-forward-observation-risk-control.v1.schema.json @<PROJECT_ID>
  • .github/CODEOWNERS:20: /schemas/qsl-reconcile-only-risk-control.v1.schema.json @<PROJECT_ID>
  • .github/CODEOWNERS:21: /scripts/provision_binance_recovery_credentials.sh @<PROJECT_ID>
  • .github/CODEOWNERS:22: /scripts/provision_soxl_v7_review_credential.py @<PROJECT_ID>
  • .github/CODEOWNERS:23: /web/strategy-switch-console/application/console_api/strategy_execution.js @<PROJECT_ID>

@Pigbibi

Pigbibi commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

Please review exact head ceb249d. This is a Draft-only release-entry repair; no deployment is requested.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T23:31:36.560839Z b755e21 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: ceb249d812

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi
Pigbibi marked this pull request as ready for review November 6, 2026 22:13

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ceb249d812

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi

Pigbibi commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

Please review exact head b755e21, addressing discussion_r4498195851. Version-pinned publication is exercised by the actual workflow publisher regression. No merge or deployment is requested.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: b755e21620

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi Pigbibi added the agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation label Nov 7, 2026
@Pigbibi
Pigbibi merged commit da87e9d into main Nov 7, 2026
20 of 21 checks passed
@Pigbibi
Pigbibi deleted the fix/reviewed-main-frontend-release branch November 7, 2026 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant