Skip to content

fix: Prepare short IBKR Cloud Run service names - #982

Merged
Pigbibi merged 1 commit into
mainfrom
fix/short-service-name-plan
Nov 6, 2026
Merged

Pigbibi merged 1 commit into
mainfrom
fix/short-service-name-plan

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

AI assistance

Codex, GPT-6.1 Sol. Independent exact-head review is requested separately with @codex; no independent acceptance is preclaimed.

What changed

Prepare account-free short IBKR Cloud Run names in the checked-in example configuration. Replace the four long <PROJECT_ID> live service names with short demo names, update manifest/matrix expectations, and test the existing shared tag allocator against each example. Document the protected inventory fields and staged replacement/consumer migration contract.

The exact four private old-to-new pairs were resolved from a fresh read-only protected inventory lookup and remain in restricted operational authority metadata (S07-C01..S07-C04), outside this public repository. All originals are length 48; the four proposed private destinations are length 26, so a 13-character candidate tag gives 39 <= 46. Public demo names are length 30 (combined 43); they are not production bindings. All five example targets remain disabled, with the shadow target unchanged.

How verified

  • Four allocation regressions failed before the configuration change (TAG_IMPOSSIBLE), then passed.
  • Final focused suite: 64 passed (manifest, matrix, shared tag policy and sync-plan consumers).
  • Full suite: 6656 passed, 6 skipped, 368 subtests passed, 8 warnings; exit 0. The initial four matrix-expectation failures were corrected without changing assertions; the complete suite was rerun.
  • Ruff, workflow shell contract, startup validation (11 routes), QPK pin consistency, offline lock check, manifest validation and diff whitespace checks passed.
  • Documentation: 0 blocking, 1 existing README outline advisory. Isolated research CI is not locally claimed.

Why

S07 owner authority t1318s7682 authorizes Draft-only preparation for the four IBKR TAG_IMPOSSIBLE services. Historical coordinator-verified inventory has 10 services: four impossible and six OK. A service name of 48 cannot fit a nonempty tag within 46; helper adoption alone (#976 source-only merge) cannot fix that budget. Cloud inventory is historical, not a fresh runtime observation.

The production service map is protected configuration, not tracked source. This PR updates source configuration examples and the migration contract; it does not write that protected map or rename/create a deployed service. Existing callers already consume explicit service names and reject identity mismatches through tag preflight. No runtime helper or workflow change is needed for the source-only preparation.

Risk

Configuration/example and test changes only; no execution or lifecycle implementation changed. A real service replacement changes runtime identity and requires continuity/release revalidation, destination ownership checks and coordinated consumer migration. Old claims or fingerprints cannot be copied forward as proof. These are future operational gates, not verified by this Draft.

Engineering disposition under owner t1298=C and S07 t1318s7682: ready-for-review, agent-approved clearing label and ordinary merge are authorized only after current exact-head CLEAN review and all required checks pass. This supersedes the initial Draft-only publication stage. The result is MERGED_NO_DEPLOY only. No deploy, service rename, traffic, Environment approval, protected configuration write, IAM, Secret, Scheduler, PAPER, live, Kelly, stop-loss or Mac action is authorized. LB #707 is excluded. Migration/deployment requires a separate owner card bound to the exact mapping and merged revision.

Publication scan

Central checker publication-check/2.0-advisory, build 83d9d1130377, advisory completed, exit 0. Full tracked-tree findings: 2570; matching lines: 2445. Changed-artifact follow-up findings: 6, matching lines: 6. Counts include existing repository material and fake fixtures, not a credential determination. No new raw binding or credential is included in the patch.

First 20 shared-masked observations:

  • .env.example:11: IB_GATEWAY_HOST=<PROJECT_ID>
  • .env.example:19: TELEGRAM_TOKEN=<<HOST>>
  • .<PROJECT_ID>/CODEOWNERS:9: /.env.example @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:10: /.github/CODEOWNERS @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:11: /application/account_new_risk_gate_support.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:12: /application/execution_kernel_adapter.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:13: /application/execution_receipt_adapter.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:14: /application/execution_service.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:15: /application/ibkr_order_execution.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:16: /application/paper_execution_admission.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:17: /application/paper_execution_command_consumer.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:18: /application/portfolio_risk_diagnostics.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:19: /application/relative_risk_preview.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:20: /application/tqqq_offline_risk.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:21: /runtime_execution_policy.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:22: /scripts/deploy_notification_only.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:23: /scripts/deploy_pilot_no_traffic.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:24: /scripts/execution_report_heartbeat.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:25: /scripts/ibkr_deployment_audit.py @<PROJECT_ID>
  • .<PROJECT_ID>/CODEOWNERS:26: /scripts/summarize_execution_ledger_cloud.py @<PROJECT_ID>

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T16:07:28.197850Z 7a5712e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Pigbibi

Pigbibi commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review exact head 7a5712e1fb852de8b25e7f264ea6405e4e98b6d7 against base d7e1ddfa0e94fa9062ebc828723e7613cc3d0661 and all four changed files. This is S07 source-only short-name preparation; keep this PR OPEN Draft. No deployment, protected inventory write, traffic, label, merge or LB #707 action is authorized.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 7a5712e1fb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Pigbibi
Pigbibi marked this pull request as ready for review November 6, 2026 16:05
@Pigbibi Pigbibi added the agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation label Nov 6, 2026
@Pigbibi
Pigbibi merged commit 097c16d into main Nov 6, 2026
17 of 20 checks passed
@Pigbibi
Pigbibi deleted the fix/short-service-name-plan branch November 6, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-approved An agent cleared this high-risk change on the current head; not an owner confirmation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant