Repository navigation
feat: Add protected four-target migration entry - #984
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review Please review the complete four-file Draft diff at exact head Scope: the protected four-target short-name observation/inert initialization workflow, operator, adverse tests and documentation. Focus on exact plan/run authorization, create-only ownership/concurrency, expiry after token acquisition, provider failure/redaction, and explicit inert revision/traffic readback. Full offline: 6699 passed, 6 skipped and 368 subtests passed; focused: 43 passed. Keep OPEN Draft. No merge, undraft, labels, dispatch, cutover or production operation is requested. Authority t1320s7739 is definition-only; t1320s7726 deployment scope is retained for a later separate card; P01 authority is untouched. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 599516faeb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please re-review the complete four-file Draft diff at exact head All three prior findings are repaired: validate-only operation completion before any create (4495487489), authenticated numeric project operation identity (4495487503), and service-level zero minimum (4495487517). Behavioral fail-before: 21 failed / 44 passed; final focused: 71 passed; full offline: 6778 passed, 6 skipped and 368 subtests passed. Existing finding threads are retained for your disposition. Keep OPEN Draft. This is the one exact-head re-review request for s07-ibkr984-review-fix-r1. No merge, undraft, labels, workflow dispatch, deploy, migration, Secret/IAM or trading action is requested. Retain t1320s7726 for a later separate deployment card; P01 authority remains untouched. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Pigbibi
added
the
agent-approved
What changed
Add a manual, main-only protected Actions channel for four short-name destinations. Observe destinations or initialize absent destinations as inert internal services with a fixed HTTP 503 process, no application environment/Secret/volume and zero minimum instances. Preserve existing services, traffic, inventory and deployment workflows.
Repair all three Codex findings from head 599516f:
Synchronize origin/main through git merge. Current head
96225ba89780334ece5a89ce27666349e6f44229; checked maina6a0ff479630c071532c9ad40a59153a4423cdc2. The complete PR remains four files: workflow, operator, tests and existing documentation. This repair edits the latter three only.Why
Validation failures could previously produce a false success and proceed to four creates. Numeric project operation names could stop polling after creation. Service-level minimum drift could pass the disabled contract. These changes enforce the existing contract without adding another release path.
Verification
Adverse coverage includes failed/unknown/timeout validation, pending-operation sequencing, expiry during polling, project/region mismatch, service minimum drift and fixed safe CLI errors. Existing concurrent-creator, mutation-no-retry, attempt-1 and expiry-after-token contracts remain green.
Risk and limits
High: protected workflow/operator. Native provider behavior, Environment protection, actual identity/permissions, destination readiness/traffic and deployed adoption remain NOT_PROVEN. Unknown creation outcomes still require private reconciliation and a separate continuation authorization; there is no mutation retry or automatic rollback.
Keep OPEN Draft. No merge, undraft, label, workflow dispatch, deploy, migration, cloud/Secret/IAM, PAPER, Live, Kelly or stop-loss action is included. Draft authority t1320s7739 is retained; t1320s7726 deployment scope remains for a later separate card; P01 authority is untouched. Existing finding threads remain visible pending independent exact-head re-review.
AI assistance
Codex (gpt-6.1-sol) authored the repair. The established review-and-merge bot is requested to re-review the new exact head once; independent acceptance is pending.
Central publication checker
publication-check/2.0-advisory build
83d9d1130377: advisory scan of the complete tracked candidate tree, exit 0; 2594 findings / 2469 matching lines across 313 files. Existing matches and fake fixtures are advisory; no real credential is introduced. Reports retain counts and file names only.First 20 masked matches: